From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41198C56201 for ; Wed, 28 Oct 2020 22:18:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E23B6206E9 for ; Wed, 28 Oct 2020 22:18:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603923538; bh=P7c4bOTUqJL1K3sIAdeq9Skrg7YWtzHj1bj36iol3sk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=MFAFbEhIa2Dam/R4M3rKvSaK/hj9EZNrCPKQ5CkO0uejiCM7NSh+qMqB7fHCeVgOQ 7JL0bUkivNkbaobClfXNL+8ogqhcbir3+FieQjfAlBRxeJlTBV/kOtk/tF+4SGsdj1 nk4NoVFVZ6xIV6p5tfrPYbJf7ALGN37ik6tChWi8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732134AbgJ1WSd (ORCPT ); Wed, 28 Oct 2020 18:18:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:60548 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731747AbgJ1WRo (ORCPT ); Wed, 28 Oct 2020 18:17:44 -0400 Received: from localhost (unknown [122.171.163.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4968E207DE; Wed, 28 Oct 2020 05:52:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603864339; bh=P7c4bOTUqJL1K3sIAdeq9Skrg7YWtzHj1bj36iol3sk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HP0BdWTBW0SRlhwiC8W3xnh0G23DSa3UhTs++DhWbFh4ttKkggCPSdzX/jeNrF/nh XA6DKIuD5rSgt8JUOiNSwlo7lHZi4nF1jifrIAhHy0jWbrjbyjbEzoYczmbi/aueNG JHplevZhmwuBaGqPal8B1iKgMNjRrPBxdNVbIkr8= Date: Wed, 28 Oct 2020 11:22:14 +0530 From: Vinod Koul To: Arnd Bergmann Cc: Peter Ujfalusi , Grygorii Strashko , Arnd Bergmann , Dan Williams , Yu Kuai , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: ti: k3-udma: fix -Wenum-conversion warning Message-ID: <20201028055214.GG3550@vkoul-mobl> References: <20201026160123.3704531-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201026160123.3704531-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26-10-20, 17:01, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc warns about a mismatch argument type when passing > 'false' into a function that expects an enum: > > drivers/dma/ti/k3-udma-private.c: In function 'xudma_tchan_get': > drivers/dma/ti/k3-udma-private.c:86:34: warning: implicit conversion from 'enum ' to 'enum udma_tp_level' [-Wenum-conversion] > 86 | return __udma_reserve_##res(ud, false, id); \ > | ^~~~~ > drivers/dma/ti/k3-udma-private.c:95:1: note: in expansion of macro 'XUDMA_GET_PUT_RESOURCE' > 95 | XUDMA_GET_PUT_RESOURCE(tchan); > | ^~~~~~~~~~~~~~~~~~~~~~ > > In this case, false has the same numerical value as > UDMA_TP_NORMAL, so passing that is most likely the correct > way to avoid the warning without changing the behavior. Applied, thanks -- ~Vinod