From: Leo Yan <leo.yan@linaro.org>
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"John Garry" <john.garry@huawei.com>,
"Will Deacon" <will@kernel.org>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Kemeng Shi" <shikemeng@huawei.com>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
"Ian Rogers" <irogers@google.com>, "Al Grant" <Al.Grant@arm.com>,
"James Clark" <james.clark@arm.com>,
"Wei Li" <liwei391@huawei.com>,
"André Przywara" <andre.przywara@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v3 1/9] perf mem: Search event name with more flexible path
Date: Wed, 28 Oct 2020 14:38:05 +0800 [thread overview]
Message-ID: <20201028063813.8562-2-leo.yan@linaro.org> (raw)
In-Reply-To: <20201028063813.8562-1-leo.yan@linaro.org>
Perf tool searches memory event name under the folder
'/sys/devices/cpu/events/', this leads to the limitation for selection
memory profiling event which must be under this folder. Thus it's
impossible to use any other event as memory event which is not under
this specific folder, e.g. Arm SPE hardware event is not located in
'/sys/devices/cpu/events/' so it cannot be enabled for memory profiling.
This patch changes to search folder from '/sys/devices/cpu/events/' to
'/sys/devices', so it give flexibility to find events which can be used
for memory profiling.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
---
tools/perf/util/mem-events.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c
index ea0af0bc4314..35c8d175a9d2 100644
--- a/tools/perf/util/mem-events.c
+++ b/tools/perf/util/mem-events.c
@@ -18,8 +18,8 @@ unsigned int perf_mem_events__loads_ldlat = 30;
#define E(t, n, s) { .tag = t, .name = n, .sysfs_name = s }
struct perf_mem_event perf_mem_events[PERF_MEM_EVENTS__MAX] = {
- E("ldlat-loads", "cpu/mem-loads,ldlat=%u/P", "mem-loads"),
- E("ldlat-stores", "cpu/mem-stores/P", "mem-stores"),
+ E("ldlat-loads", "cpu/mem-loads,ldlat=%u/P", "cpu/events/mem-loads"),
+ E("ldlat-stores", "cpu/mem-stores/P", "cpu/events/mem-stores"),
};
#undef E
@@ -93,7 +93,7 @@ int perf_mem_events__init(void)
struct perf_mem_event *e = &perf_mem_events[j];
struct stat st;
- scnprintf(path, PATH_MAX, "%s/devices/cpu/events/%s",
+ scnprintf(path, PATH_MAX, "%s/devices/%s",
mnt, e->sysfs_name);
if (!stat(path, &st))
--
2.17.1
next prev parent reply other threads:[~2020-10-28 22:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 6:38 [PATCH v3 0/9] perf mem/c2c: Support AUX trace Leo Yan
2020-10-28 6:38 ` Leo Yan [this message]
2020-10-28 6:38 ` [PATCH v3 2/9] perf mem: Introduce weak function perf_mem_events__ptr() Leo Yan
2020-10-28 6:38 ` [PATCH v3 3/9] perf mem: Support new memory event PERF_MEM_EVENTS__LOAD_STORE Leo Yan
2020-10-31 20:23 ` Jiri Olsa
2020-11-02 9:38 ` Leo Yan
2020-10-28 6:38 ` [PATCH v3 4/9] perf mem: Only initialize memory event for recording Leo Yan
2020-10-30 1:04 ` Ian Rogers
2020-10-28 6:38 ` [PATCH v3 5/9] perf mem: Support AUX trace Leo Yan
2020-10-28 6:38 ` [PATCH v3 6/9] perf c2c: " Leo Yan
2020-10-31 20:21 ` Jiri Olsa
2020-11-02 10:08 ` Leo Yan
2020-11-02 16:35 ` Jiri Olsa
2020-10-28 6:38 ` [PATCH v3 7/9] perf mem: Support Arm SPE events Leo Yan
2020-10-28 6:38 ` [PATCH v3 8/9] perf mem: Return NULL for event 'ldst' on PowerPC Leo Yan
2020-10-28 9:35 ` Naveen N. Rao
2020-10-28 6:38 ` [PATCH v3 9/9] perf mem: Document event type 'ldst' Leo Yan
2020-10-30 1:10 ` Ian Rogers
2020-10-30 1:49 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028063813.8562-2-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=Al.Grant@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andre.przywara@arm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=shikemeng@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).