From: Guru Das Srinagesh <gurus@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org,
Subbaraman Narayanamurthy <subbaram@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Stephen Boyd <sboyd@kernel.org>,
Anirudh Ghayal <aghayal@codeaurora.org>
Subject: Re: [PATCH v3 1/2] bindings: pm8941-misc: Convert to YAML and add support for VBUS detection
Date: Wed, 28 Oct 2020 00:08:36 -0700 [thread overview]
Message-ID: <20201028070836.GA10441@codeaurora.org> (raw)
In-Reply-To: <20201023161409.GB2790207@bogus>
On Fri, Oct 23, 2020 at 11:14:09AM -0500, Rob Herring wrote:
> On Thu, Oct 22, 2020 at 02:47:43PM -0700, Guru Das Srinagesh wrote:
> > From: Anirudh Ghayal <aghayal@codeaurora.org>
> >
> > Convert bindings to YAML. Also add compatible string that adds support
> > for reporting the VBUS status that can be detected via a dedicated PMIC
> > pin.
>
> Converting to yaml and add Vbus support should be 2 patches.
Done.
>
> Really, the main pm8941 needs to be converted and then this one
> referenced by it.
Could you please explain a bit more on what this might look like?
>
...
> > +
> > +description: |
> > + Some Qualcomm PMICs have a "misc" module that can be used to detect when
> > + the USB ID pin has been pulled low or high.
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - items:
>
> Don't need oneOf for a single entry.
Done.
>
> > + - enum:
> > + - qcom,pm8941-misc
> > + - qcom,pmd-vbus-det
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 2
>
> Need 'minItems: 1' if 1 or 2 interrupts is valid.
Done.
>
> > +
> > + interrupt-names:
> > + anyOf:
> > + - items:
>
> Don't need 'anyOf'
Done.
>
> > + - enum:
> > + - usb_id
> > + - usb_vbus
>
> I think what you want here is:
>
> minItems: 1
> items:
> - const: usb_id
> - const: usb_vbus
>
> Meaning 'usb_id' is always present and 'usb_vbus' is optional 2nd
> interrupt.
Done.
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - interrupt-names
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > + pmic {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + interrupt-controller;
> > + #interrupt-cells = <4>;
> > +
> > + usb_id: misc@900 {
> > + compatible = "qcom,pm8941-misc";
> > + reg = <0x900>;
> > + interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
> > + interrupt-names = "usb_id";
> > + };
> > + };
> > +
> > + usb-controller {
> > + extcon = <&usb_id>;
> > + };
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >
next prev parent reply other threads:[~2020-10-28 23:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 21:47 [PATCH v3 0/2] Add support for VBUS detection Guru Das Srinagesh
2020-10-22 21:47 ` [PATCH v3 1/2] bindings: pm8941-misc: Convert to YAML and add " Guru Das Srinagesh
2020-10-23 16:06 ` Rob Herring
2020-10-23 16:14 ` Rob Herring
2020-10-28 7:08 ` Guru Das Srinagesh [this message]
2020-10-22 21:47 ` [PATCH v3 2/2] extcon: qcom-spmi: Add " Guru Das Srinagesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028070836.GA10441@codeaurora.org \
--to=gurus@codeaurora.org \
--cc=aghayal@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=collinsd@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=subbaram@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox