From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22FCCC388F7 for ; Wed, 28 Oct 2020 23:15:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CD4C520759 for ; Wed, 28 Oct 2020 23:15:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390264AbgJ1XPA (ORCPT ); Wed, 28 Oct 2020 19:15:00 -0400 Received: from alexa-out-sd-01.qualcomm.com ([199.106.114.38]:30309 "EHLO alexa-out-sd-01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389529AbgJ1XO7 (ORCPT ); Wed, 28 Oct 2020 19:14:59 -0400 Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-01.qualcomm.com with ESMTP; 28 Oct 2020 00:08:36 -0700 X-QCInternal: smtphost Received: from gurus-linux.qualcomm.com ([10.46.162.81]) by ironmsg04-sd.qualcomm.com with ESMTP; 28 Oct 2020 00:08:36 -0700 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id 713D1199D; Wed, 28 Oct 2020 00:08:36 -0700 (PDT) Date: Wed, 28 Oct 2020 00:08:36 -0700 From: Guru Das Srinagesh To: Rob Herring Cc: Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, Subbaraman Narayanamurthy , David Collins , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , Anirudh Ghayal Subject: Re: [PATCH v3 1/2] bindings: pm8941-misc: Convert to YAML and add support for VBUS detection Message-ID: <20201028070836.GA10441@codeaurora.org> References: <20201023161409.GB2790207@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201023161409.GB2790207@bogus> User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 23, 2020 at 11:14:09AM -0500, Rob Herring wrote: > On Thu, Oct 22, 2020 at 02:47:43PM -0700, Guru Das Srinagesh wrote: > > From: Anirudh Ghayal > > > > Convert bindings to YAML. Also add compatible string that adds support > > for reporting the VBUS status that can be detected via a dedicated PMIC > > pin. > > Converting to yaml and add Vbus support should be 2 patches. Done. > > Really, the main pm8941 needs to be converted and then this one > referenced by it. Could you please explain a bit more on what this might look like? > ... > > + > > +description: | > > + Some Qualcomm PMICs have a "misc" module that can be used to detect when > > + the USB ID pin has been pulled low or high. > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > Don't need oneOf for a single entry. Done. > > > + - enum: > > + - qcom,pm8941-misc > > + - qcom,pmd-vbus-det > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 2 > > Need 'minItems: 1' if 1 or 2 interrupts is valid. Done. > > > + > > + interrupt-names: > > + anyOf: > > + - items: > > Don't need 'anyOf' Done. > > > + - enum: > > + - usb_id > > + - usb_vbus > > I think what you want here is: > > minItems: 1 > items: > - const: usb_id > - const: usb_vbus > > Meaning 'usb_id' is always present and 'usb_vbus' is optional 2nd > interrupt. Done. > > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - interrupt-names > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + pmic { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + interrupt-controller; > > + #interrupt-cells = <4>; > > + > > + usb_id: misc@900 { > > + compatible = "qcom,pm8941-misc"; > > + reg = <0x900>; > > + interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>; > > + interrupt-names = "usb_id"; > > + }; > > + }; > > + > > + usb-controller { > > + extcon = <&usb_id>; > > + }; > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > > a Linux Foundation Collaborative Project > >