From: Krzysztof Kozlowski <krzk@kernel.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Wolfram Sang <wsa@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
linux-i2c@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: exynos5: fix platform_get_irq error handling
Date: Wed, 28 Oct 2020 08:21:54 +0100 [thread overview]
Message-ID: <20201028072154.GA3494@kozik-lap> (raw)
In-Reply-To: <20201027214257.8099-1-martin@kaiser.cx>
On Tue, Oct 27, 2020 at 10:42:57PM +0100, Martin Kaiser wrote:
> platform_get_irq already prints an error message if the requested irq
> was not found. Don't print another message in the driver.
>
> If platform_get_irq returns an error, relay this error to the caller of the
> probe function. Don't change all errors to -EINVAL. This breaks the case
> where platform_get_irq returns -EPROBE_DEFER.
>
> platform_get_irq never returns 0. Don't check for this. Make it clear that
> the error path always returns a negative error code.
These should be three separate commits.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-10-29 0:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 21:42 [PATCH] i2c: exynos5: fix platform_get_irq error handling Martin Kaiser
2020-10-28 7:21 ` Krzysztof Kozlowski [this message]
2020-11-01 17:18 ` [PATCH v2 1/3] i2c: exynos5: remove duplicate error message Martin Kaiser
2020-11-01 17:18 ` [PATCH v2 2/3] i2c: exynos5: fix platform_get_irq error handling Martin Kaiser
2020-11-02 8:39 ` Krzysztof Kozlowski
2020-11-01 17:18 ` [PATCH v2 3/3] i2c: exynos5: don't check for irq 0 Martin Kaiser
2020-11-02 8:37 ` Krzysztof Kozlowski
2020-11-02 8:37 ` [PATCH v2 1/3] i2c: exynos5: remove duplicate error message Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028072154.GA3494@kozik-lap \
--to=krzk@kernel.org \
--cc=a.hajda@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=martin@kaiser.cx \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).