From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D88CC4363A for ; Wed, 28 Oct 2020 22:36:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 245AD20725 for ; Wed, 28 Oct 2020 22:36:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388433AbgJ1Wg1 (ORCPT ); Wed, 28 Oct 2020 18:36:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:51270 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388081AbgJ1Wdl (ORCPT ); Wed, 28 Oct 2020 18:33:41 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DB137AC0C; Wed, 28 Oct 2020 09:04:56 +0000 (UTC) Date: Wed, 28 Oct 2020 10:04:55 +0100 From: Jean Delvare To: Kai-Chuan Hsieh Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware/dmi: Include product_sku info to modalias Message-ID: <20201028100455.28cad0f5@endymion> In-Reply-To: <20201028035015.8897-1-kaichuan.hsieh@canonical.com> References: <20201028035015.8897-1-kaichuan.hsieh@canonical.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kai-Chuan, On Wed, 28 Oct 2020 11:50:15 +0800, Kai-Chuan Hsieh wrote: > Some Dell platforms rely on modalias to customize configuration, > the product sku can be more specific for the hardware. > > Add product_sku to modalias for better utilization. > > Signed-off-by: Kai-Chuan Hsieh > --- > drivers/firmware/dmi-id.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/dmi-id.c b/drivers/firmware/dmi-id.c > index 86d71b0212b1..4d5421d14a41 100644 > --- a/drivers/firmware/dmi-id.c > +++ b/drivers/firmware/dmi-id.c > @@ -85,6 +85,7 @@ static ssize_t get_modalias(char *buffer, size_t buffer_size) > { "svn", DMI_SYS_VENDOR }, > { "pn", DMI_PRODUCT_NAME }, > { "pvr", DMI_PRODUCT_VERSION }, > + { "sku", DMI_PRODUCT_SKU }, > { "rvn", DMI_BOARD_VENDOR }, > { "rn", DMI_BOARD_NAME }, > { "rvr", DMI_BOARD_VERSION }, Applied, thanks. For your future submissions, I invite you to read Documentation/process/submitting-patches.rst Specifically, when submitting a new version of a patch, please: * Replace [PATCH] with [PATCH v2] in the subject. * Do not reply to the previous version of the patch, instead start a new thread. * Ideally, include a list of changes from previous version, between the "---" marker and the diffstat. Thanks, -- Jean Delvare SUSE L3 Support