From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C972C4363A for ; Thu, 29 Oct 2020 00:59:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A28420790 for ; Thu, 29 Oct 2020 00:59:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403914AbgJ2A70 (ORCPT ); Wed, 28 Oct 2020 20:59:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:60502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731564AbgJ1WRa (ORCPT ); Wed, 28 Oct 2020 18:17:30 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C80124741; Wed, 28 Oct 2020 13:19:11 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.94) (envelope-from ) id 1kXlM6-005a7S-1m; Wed, 28 Oct 2020 09:19:10 -0400 Message-ID: <20201028131909.923504298@goodmis.org> User-Agent: quilt/0.66 Date: Wed, 28 Oct 2020 09:15:44 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Andrew Morton , Jiri Olsa , Thomas Gleixner , Peter Zijlstra , Ingo Molnar , Alexei Starovoitov Subject: [RFC][PATCH 2/2] ftrace: Test arguments by adding trace_printk in function tracer References: <20201028131542.963014814@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Steven Rostedt (VMware)" Signed-off-by: Steven Rostedt (VMware) --- kernel/trace/trace_functions.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace_functions.c b/kernel/trace/trace_functions.c index 89c414ce1388..4bd3194540f1 100644 --- a/kernel/trace/trace_functions.c +++ b/kernel/trace/trace_functions.c @@ -129,7 +129,7 @@ static void function_trace_start(struct trace_array *tr) static void function_trace_call(unsigned long ip, unsigned long parent_ip, - struct ftrace_ops *op, struct pt_regs *pt_regs) + struct ftrace_ops *op, struct pt_regs *regs) { struct trace_array *tr = op->private; struct trace_array_cpu *data; @@ -153,6 +153,17 @@ function_trace_call(unsigned long ip, unsigned long parent_ip, if (!atomic_read(&data->disabled)) { local_save_flags(flags); trace_function(tr, ip, parent_ip, flags, pc); +#ifdef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS + trace_printk("%pS %lx %lx %lx %lx %lx %lx %lx\n", + (void *)ip, + kernel_stack_pointer(regs), + regs_get_kernel_argument(regs, 0), + regs_get_kernel_argument(regs, 1), + regs_get_kernel_argument(regs, 2), + regs_get_kernel_argument(regs, 3), + regs_get_kernel_argument(regs, 4), + regs_get_kernel_argument(regs, 5)); +#endif } ftrace_test_recursion_unlock(bit); preempt_enable_notrace(); -- 2.28.0