From: Joerg Roedel <jroedel@suse.de>
To: Arvind Sankar <nivedita@alum.mit.edu>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
x86@kernel.org,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm/ident_map: Check for errors from ident_pud_init()
Date: Wed, 28 Oct 2020 14:29:54 +0100 [thread overview]
Message-ID: <20201028132954.GK22179@suse.de> (raw)
In-Reply-To: <20201027230648.1885111-1-nivedita@alum.mit.edu>
On Tue, Oct 27, 2020 at 07:06:48PM -0400, Arvind Sankar wrote:
> Commit
> ea3b5e60ce80 ("x86/mm/ident_map: Add 5-level paging support")
> added ident_p4d_init() to support 5-level paging, but this function
> doesn't check and return errors from ident_pud_init().
>
> For example, the decompressor stub uses this code to create an identity
> mapping. If it runs out of pages while trying to allocate a PMD
> pagetable, the error will be currently ignored.
>
> Fix this to propagate errors.
>
> Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
> Fixes: ea3b5e60ce80 ("x86/mm/ident_map: Add 5-level paging support")
> ---
> arch/x86/mm/ident_map.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Joerg Roedel <jroedel@suse.de>
next prev parent reply other threads:[~2020-10-28 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 23:06 [PATCH] x86/mm/ident_map: Check for errors from ident_pud_init() Arvind Sankar
2020-10-28 13:29 ` Joerg Roedel [this message]
2020-10-28 13:56 ` [tip: x86/mm] " tip-bot2 for Arvind Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028132954.GK22179@suse.de \
--to=jroedel@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox