* [PATCH] char: misc: increase DYNAMIC_MINORS value
[not found] <CGME20201029063539epcas1p36375a73634374656654da00cbaf91531@epcas1p3.samsung.com>
@ 2020-10-29 6:28 ` Sangmoon Kim
2020-10-29 7:05 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sangmoon Kim @ 2020-10-29 6:28 UTC (permalink / raw)
To: arnd, gregkh; +Cc: linux-kernel, Sangmoon Kim
DYNAMIC_MINORS value has been set to 64.
Due to this reason, we are facing a module loading fail problem of
device driver like below.
[ 45.712771] pdic_misc_init - return error : -16
We need to increase this value for registering more misc devices.
Signed-off-by: Sangmoon Kim <sangmoon.kim@samsung.com>
---
drivers/char/misc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index f6a147427029..ca5141ed5ef3 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -60,7 +60,7 @@ static DEFINE_MUTEX(misc_mtx);
/*
* Assigned numbers, used for dynamic minors
*/
-#define DYNAMIC_MINORS 64 /* like dynamic majors */
+#define DYNAMIC_MINORS 128 /* like dynamic majors */
static DECLARE_BITMAP(misc_minors, DYNAMIC_MINORS);
#ifdef CONFIG_PROC_FS
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] char: misc: increase DYNAMIC_MINORS value
2020-10-29 6:28 ` [PATCH] char: misc: increase DYNAMIC_MINORS value Sangmoon Kim
@ 2020-10-29 7:05 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2020-10-29 7:05 UTC (permalink / raw)
To: Sangmoon Kim; +Cc: arnd, linux-kernel
On Thu, Oct 29, 2020 at 03:28:55PM +0900, Sangmoon Kim wrote:
> DYNAMIC_MINORS value has been set to 64.
> Due to this reason, we are facing a module loading fail problem of
> device driver like below.
>
> [ 45.712771] pdic_misc_init - return error : -16
>
> We need to increase this value for registering more misc devices.
That's a lot of misc devices, nice to see it used more now :)
I'll go queue this up, thanks!
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-29 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20201029063539epcas1p36375a73634374656654da00cbaf91531@epcas1p3.samsung.com>
2020-10-29 6:28 ` [PATCH] char: misc: increase DYNAMIC_MINORS value Sangmoon Kim
2020-10-29 7:05 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox