The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xu Wang <vulab@iscas.ac.cn>
Cc: sbkim73@samsung.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: samsung: i2s: Remove redundant null check before clk_disable_unprepare
Date: Thu, 29 Oct 2020 19:36:51 +0100	[thread overview]
Message-ID: <20201029183651.GA90952@kozik-lap> (raw)
In-Reply-To: <20201029083715.28561-1-vulab@iscas.ac.cn>

On Thu, Oct 29, 2020 at 08:37:15AM +0000, Xu Wang wrote:
> Because clk_disable_unprepare() already checked NULL clock parameter,
> so the additional check is unnecessary, just remove it.

You missed other places with it - the resume part.

Best regards,
Krzysztof

> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
>  sound/soc/samsung/i2s.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

      reply	other threads:[~2020-10-29 18:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29  8:37 [PATCH] ASoC: samsung: i2s: Remove redundant null check before clk_disable_unprepare Xu Wang
2020-10-29 18:36 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201029183651.GA90952@kozik-lap \
    --to=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sbkim73@samsung.com \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox