Re: [PATCH] leds: various: add missing put_device() call in netxbig_leds_get_of_pdata()

Pavel Machek
2020-10-29T17:49:57Z

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Hi!

> if of_find_device_by_node() succeed, netxbig_leds_get_of_pdata() doesn't
> have a corresponding put_device(). Thus add jump target to fix the
> exception handling for this function implementation.
>
> Fixes: 2976b1798909 ("leds: netxbig: add device tree binding")
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>

Thanks, applied.

But it seems to me similar handling is needed in "success" paths, no?

Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]