Re: [RFC PATCH v3 9/9] ipu3-cio2: Add functionality allowing software_node connections to sensors on platforms designed for Windows

Andy Shevchenko
2020-10-22T13:39:39Z

On Thu, Oct 22, 2020 at 3:59 PM Daniel Scally <djrscally@gmail.com> wrote:
> On 20/10/2020 10:41, Andy Shevchenko wrote:

...

> >> +static const char * const port_names[] = {
> >> + "port0", "port1", "port2", "port3"
> > + comma.
> I think 4 ports is the maximum for CIO2 device, so this shouldn't ever
> get extended?

It's better for at least teaching purposes (if anybody takes this
driver as an example for anything) if you have really believe that no
new generation will have more than that.

...

> >> + if (is_software_node(dev_fwnode(&pci_dev->dev)))
> > Can we use the same check as for _build call above?
>
> And just set a flag in struct cio2? sure.

I meant can we use exact conditional w/o any additional flags added?

--
With Best Regards,
Andy Shevchenko