From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 795A4C4742C for ; Fri, 30 Oct 2020 00:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0622120FC3 for ; Fri, 30 Oct 2020 00:10:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604016645; bh=HhMiwNSPHbCREvHc/7+74xJI9P/gWgD7l/IMkhp5LOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Y4s1iEPaNacGOkD8GLO4WXLjo1hm6v7AxuWaaKnSn+oncv3CGO8UbFUCPBcdAcjZI RsNLOTlkX2NTDLT+O7lak1SFhN6TFf8mSPEs7U3s5Ma68CBVMQO6N1fLKgfdhhaI7o b6dupKkVXwnBVPPVcpwvZdebvxW2MOKJiGTWMYKE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725909AbgJ3AKo (ORCPT ); Thu, 29 Oct 2020 20:10:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:38438 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725379AbgJ3AKn (ORCPT ); Thu, 29 Oct 2020 20:10:43 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 30CA020756; Fri, 30 Oct 2020 00:10:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604016642; bh=HhMiwNSPHbCREvHc/7+74xJI9P/gWgD7l/IMkhp5LOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XH8x1Sty0lFIjbiS8zSeHz9ZuwKUOeC//frspGgbUlyev2c0df6HBaB7yBu3Pggba AnTqORnLvlK+1qPglgef914U0kuWLx+DsmTXi3gMvxUQ6lWiv1+rD8ljAOMF+BGK1I VSfTIuRkwsoyESO8HqB4UYjF9xm5whsOiJlamm8c= Date: Fri, 30 Oct 2020 08:10:38 +0800 From: Shawn Guo To: Ioana Ciornei Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/9] arm64: dts: ls2088ardb: add PHY nodes for the CS4340 PHYs Message-ID: <20201030001038.GU28755@dragon> References: <20200925132503.30206-1-ioana.ciornei@nxp.com> <20200925132503.30206-6-ioana.ciornei@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200925132503.30206-6-ioana.ciornei@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 25, 2020 at 04:24:59PM +0300, Ioana Ciornei wrote: > Annotate the EMDIO1 node and describe the 4 10GBASER PHYs found on the > LS2088ARDB board. Also, add phy-handles for DPMACs 1-4 to their > associated PHY. > > Signed-off-by: Ioana Ciornei > --- > .../boot/dts/freescale/fsl-ls2088a-rdb.dts | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts > index f6b4d75a258b..0d1935fcd201 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2088a-rdb.dts > @@ -22,3 +22,44 @@ chosen { > stdout-path = "serial1:115200n8"; > }; > }; > + > +&dpmac1 { > + phy-handle = <&mdio1_phy1>; > +}; > + > +&dpmac2 { > + phy-handle = <&mdio1_phy2>; > +}; > + > +&dpmac3 { > + phy-handle = <&mdio1_phy3>; > +}; > + > +&dpmac4 { > + phy-handle = <&mdio1_phy4>; > +}; > + > +&emdio1 { > + status = "okay"; > + > + mdio1_phy1: emdio1_phy@1 { > + compatible = "ethernet-phy-id13e5.1002"; > + reg = <0x10>; > + phy-connection-type = "10gbase-r"; > + }; Please have a newline between nodes. Shawn > + mdio1_phy2: emdio1_phy@2 { > + compatible = "ethernet-phy-id13e5.1002"; > + reg = <0x11>; > + phy-connection-type = "10gbase-r"; > + }; > + mdio1_phy3: emdio1_phy@3 { > + compatible = "ethernet-phy-id13e5.1002"; > + reg = <0x12>; > + phy-connection-type = "10gbase-r"; > + }; > + mdio1_phy4: emdio1_phy@4 { > + compatible = "ethernet-phy-id13e5.1002"; > + reg = <0x13>; > + phy-connection-type = "10gbase-r"; > + }; > +}; > -- > 2.25.1 >