From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: John Donnelly <john.p.donnelly@oracle.com>
Cc: linux-kernel@vger.kernel.org, trix@redhat.com
Subject: Re: [PATCH 4.14 v2 ] platform/x86: Corrects warning: missing braces around initializer
Date: Fri, 30 Oct 2020 19:42:25 +0200 [thread overview]
Message-ID: <20201030174225.GS4077@smile.fi.intel.com> (raw)
In-Reply-To: <105E5DC2-1B23-40BF-95A1-1B8443575AF6@oracle.com>
On Fri, Oct 30, 2020 at 12:18:44PM -0500, John Donnelly wrote:
> > On Oct 30, 2020, at 11:52 AM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Fri, Oct 30, 2020 at 08:55:01AM -0700, john.p.donnelly@oracle.com wrote:
> >> From: John Donnelly <john.p.donnelly@oracle.com>
> >>
> >> The assignment statement of a local variable "struct tp_nvram_state s[2] = {0};
> >> is not valid for all versions of compilers.
> >
> > I don't get the subject. IS it backport of existing change to v4.14, or you are
> > trying to fix v4.14? If the latter is the case, it's not correct order. Try
> > latest vanilla first (v5.10-rc1 as of today) and if there is still an issue,
> > submit a patch.
>
> Hi,
>
> It is only intended for 4.14. Why would you back port a commit to a stable tree that emits warnings ?
So, if this is for stable, what is the current commit in the kernel of this?
> >> Fixes: 515ded02bc4b ("platform/x86: thinkpad_acpi: initialize tp_nvram_state variable")
> >>
> >> Signed-off-by: John Donnelly <john.p.donnelly@oracle.com>
> >
> > Should not be blank line in between.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-10-30 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 15:55 [PATCH 4.14 v2 ] platform/x86: Corrects warning: missing braces around initializer john.p.donnelly
2020-10-30 16:52 ` Andy Shevchenko
2020-10-30 17:18 ` John Donnelly
2020-10-30 17:42 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201030174225.GS4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=john.p.donnelly@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox