Re: [PATCH v2 2/2] uuid: Make guid_t completely internal type to the kernel

Andy Shevchenko
2020-11-24T14:06:49Z

On Tue, Nov 24, 2020 at 02:39:45PM +0100, Christoph Hellwig wrote:
> On Fri, Oct 30, 2020 at 08:49:50PM +0200, Andy Shevchenko wrote:
> > diff --git a/include/uapi/linux/uuid.h b/include/uapi/linux/uuid.h
> > index e5a7eecef7c3..c3e175f686f4 100644
> > --- a/include/uapi/linux/uuid.h
> > +++ b/include/uapi/linux/uuid.h
> > @@ -1,6 +1,6 @@
> > /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> > /*
> > - * UUID/GUID definition
> > + * MEI UUID definition
> > *
> > * Copyright (C) 2010, Intel Corp.
> > * Huang Ying <ying.huang@intel.com>
> > @@ -22,21 +22,17 @@
> >
> > typedef struct {
> > __u8 b[16];
> > -} guid_t;
> > +} uuid_le;
>
> IMHO we should kill this header entirely and move the definition to
> <uapi/linux/mei.h> under a new name so that no one picks up the
> definition by accident.

I would like to do that in a separate series. Here I don't change the status
quo about using it, but for moving it will require to touch MEI code.

--
With Best Regards,
Andy Shevchenko