Re: [PATCH 2/2] mailbox: stm32-ipcc: remove duplicate error message

Fabien DESSENNE
2020-10-26T08:12:34Z

Hi Martin

Thank you for the patch

On 24/10/2020 3:31 pm, Martin Kaiser wrote:
> platform_get_irq_byname already prints an error message if the requested irq
> was not found. Don't print another message in the driver.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>

Reviewed-by: Fabien Dessenne <fabien.dessenne@st.com>

> ---
> drivers/mailbox/stm32-ipcc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mailbox/stm32-ipcc.c b/drivers/mailbox/stm32-ipcc.c
> index ef966887aa15..ab8fe56af948 100644
> --- a/drivers/mailbox/stm32-ipcc.c
> +++ b/drivers/mailbox/stm32-ipcc.c
> @@ -257,9 +257,6 @@ static int stm32_ipcc_probe(struct platform_device *pdev)
> for (i = 0; i < IPCC_IRQ_NUM; i++) {
> ipcc->irqs[i] = platform_get_irq_byname(pdev, irq_name[i]);
> if (ipcc->irqs[i] < 0) {
> - if (ipcc->irqs[i] != -EPROBE_DEFER)
> - dev_err(dev, "no IRQ specified %s\n",
> - irq_name[i]);
> ret = ipcc->irqs[i];
> goto err_clk;
> }