Re: [PATCH 02/18] block: open code kobj_map into in block/genhd.c

Greg Kroah-Hartman
2020-10-30T10:39:54Z

On Thu, Oct 29, 2020 at 08:32:42PM +0100, Christoph Hellwig wrote:
> On Thu, Oct 29, 2020 at 08:22:36PM +0100, Greg Kroah-Hartman wrote:
> > After this, you want me to get rid of kobj_map, right? Or you don't
> > care as block doesn't use it anymore? :)
>
> I have a patch to kill it, but it causes odd regressions with the
> tpm driver according to the kernel test. As I have grand plans that
> build on the block ѕide of this series for 5.11, I plan to defer the
> chardev side and address it for 5.12.

Ok, sounds good.

Wow, I just looked at the tpm code, and it is, um, "interesting" in how
it thinks device lifespans work. Nothing like having 4 different
structures with different lifespans embedded within a single structure.
Good thing that no one can dynamically remove a TPM device during
"normal" operation.

greg k-h