* [PATCH] memstick: mspro_block: remove unneeded semicolon
@ 2020-10-31 13:48 trix
2020-11-02 6:51 ` kajoljain
2020-11-05 12:58 ` Ulf Hansson
0 siblings, 2 replies; 5+ messages in thread
From: trix @ 2020-10-31 13:48 UTC (permalink / raw)
To: maximlevitsky, oakad, ulf.hansson; +Cc: linux-mmc, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
A semicolon is not needed after a switch statement.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/memstick/core/mspro_block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
index cd6b8d4f2335..afb892e7ffc6 100644
--- a/drivers/memstick/core/mspro_block.c
+++ b/drivers/memstick/core/mspro_block.c
@@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
return "attr_devinfo";
default:
return NULL;
- };
+ }
}
typedef ssize_t (*sysfs_show_t)(struct device *dev,
--
2.18.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] memstick: mspro_block: remove unneeded semicolon
2020-10-31 13:48 [PATCH] memstick: mspro_block: remove unneeded semicolon trix
@ 2020-11-02 6:51 ` kajoljain
2020-11-02 13:42 ` Tom Rix
2020-11-05 12:58 ` Ulf Hansson
1 sibling, 1 reply; 5+ messages in thread
From: kajoljain @ 2020-11-02 6:51 UTC (permalink / raw)
To: trix, maximlevitsky, oakad, ulf.hansson; +Cc: linux-mmc, linux-kernel
On 10/31/20 7:18 PM, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A semicolon is not needed after a switch statement.
Hi Tom,
I was checking this patch. Not sure if it will come under as fix patch. Since this is not fixing
any logical issue do we still need to add fix tag?
Thanks,
Kajol Jain
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/memstick/core/mspro_block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
> index cd6b8d4f2335..afb892e7ffc6 100644
> --- a/drivers/memstick/core/mspro_block.c
> +++ b/drivers/memstick/core/mspro_block.c
> @@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
> return "attr_devinfo";
> default:
> return NULL;
> - };
> + }
> }
>
> typedef ssize_t (*sysfs_show_t)(struct device *dev,
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] memstick: mspro_block: remove unneeded semicolon
2020-11-02 6:51 ` kajoljain
@ 2020-11-02 13:42 ` Tom Rix
2020-11-02 16:06 ` kajoljain
0 siblings, 1 reply; 5+ messages in thread
From: Tom Rix @ 2020-11-02 13:42 UTC (permalink / raw)
To: kajoljain, maximlevitsky, oakad, ulf.hansson; +Cc: linux-mmc, linux-kernel
On 11/1/20 10:51 PM, kajoljain wrote:
>
> On 10/31/20 7:18 PM, trix@redhat.com wrote:
>> From: Tom Rix <trix@redhat.com>
>>
>> A semicolon is not needed after a switch statement.
> Hi Tom,
> I was checking this patch. Not sure if it will come under as fix patch. Since this is not fixing
> any logical issue do we still need to add fix tag?
My rule of thumb is a fix means the kernel needs to be recompiled.
This isn't a fix.
Tom
>
> Thanks,
> Kajol Jain
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> drivers/memstick/core/mspro_block.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
>> index cd6b8d4f2335..afb892e7ffc6 100644
>> --- a/drivers/memstick/core/mspro_block.c
>> +++ b/drivers/memstick/core/mspro_block.c
>> @@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
>> return "attr_devinfo";
>> default:
>> return NULL;
>> - };
>> + }
>> }
>>
>> typedef ssize_t (*sysfs_show_t)(struct device *dev,
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] memstick: mspro_block: remove unneeded semicolon
2020-11-02 13:42 ` Tom Rix
@ 2020-11-02 16:06 ` kajoljain
0 siblings, 0 replies; 5+ messages in thread
From: kajoljain @ 2020-11-02 16:06 UTC (permalink / raw)
To: Tom Rix, maximlevitsky, oakad, ulf.hansson; +Cc: linux-mmc, linux-kernel
On 11/2/20 7:12 PM, Tom Rix wrote:
>
> On 11/1/20 10:51 PM, kajoljain wrote:
>>
>> On 10/31/20 7:18 PM, trix@redhat.com wrote:
>>> From: Tom Rix <trix@redhat.com>
>>>
>>> A semicolon is not needed after a switch statement.
>> Hi Tom,
>> I was checking this patch. Not sure if it will come under as fix patch. Since this is not fixing
>> any logical issue do we still need to add fix tag?
>
> My rule of thumb is a fix means the kernel needs to be recompiled.
Yes make sense. Thanks for confirming.
Thanks,
Kajol Jain
>
> This isn't a fix.
>
> Tom
>
>>
>> Thanks,
>> Kajol Jain
>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>> ---
>>> drivers/memstick/core/mspro_block.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
>>> index cd6b8d4f2335..afb892e7ffc6 100644
>>> --- a/drivers/memstick/core/mspro_block.c
>>> +++ b/drivers/memstick/core/mspro_block.c
>>> @@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
>>> return "attr_devinfo";
>>> default:
>>> return NULL;
>>> - };
>>> + }
>>> }
>>>
>>> typedef ssize_t (*sysfs_show_t)(struct device *dev,
>>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] memstick: mspro_block: remove unneeded semicolon
2020-10-31 13:48 [PATCH] memstick: mspro_block: remove unneeded semicolon trix
2020-11-02 6:51 ` kajoljain
@ 2020-11-05 12:58 ` Ulf Hansson
1 sibling, 0 replies; 5+ messages in thread
From: Ulf Hansson @ 2020-11-05 12:58 UTC (permalink / raw)
To: trix
Cc: Maxim Levitsky, Alex Dubov, linux-mmc@vger.kernel.org,
Linux Kernel Mailing List
On Sat, 31 Oct 2020 at 14:48, <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/memstick/core/mspro_block.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
> index cd6b8d4f2335..afb892e7ffc6 100644
> --- a/drivers/memstick/core/mspro_block.c
> +++ b/drivers/memstick/core/mspro_block.c
> @@ -276,7 +276,7 @@ static const char *mspro_block_attr_name(unsigned char tag)
> return "attr_devinfo";
> default:
> return NULL;
> - };
> + }
> }
>
> typedef ssize_t (*sysfs_show_t)(struct device *dev,
> --
> 2.18.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-05 12:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-31 13:48 [PATCH] memstick: mspro_block: remove unneeded semicolon trix
2020-11-02 6:51 ` kajoljain
2020-11-02 13:42 ` Tom Rix
2020-11-02 16:06 ` kajoljain
2020-11-05 12:58 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox