From: kernel test robot <lkp@intel.com>
To: Luo Jiaxing <luojiaxing@huawei.com>,
akpm@linux-foundation.org, viro@zeniv.linux.org.uk,
andriy.shevchenko@linux.intel.com
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
martin.petersen@oracle.com, john.garry@huawei.com,
himanshu.madhani@cavium.com, felipe.balbi@linux.intel.com,
gregkh@linuxfoundation.org, uma.shankar@intel.com
Subject: Re: [PATCH v2 3/5] scsi: qla2xxx: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs
Date: Sat, 31 Oct 2020 16:45:59 +0800 [thread overview]
Message-ID: <202010311606.0Cn21JYx-lkp@intel.com> (raw)
In-Reply-To: <1604046722-15531-4-git-send-email-luojiaxing@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 4791 bytes --]
Hi Luo,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mkp-scsi/for-next]
[also build test ERROR on scsi/for-next linus/master v5.10-rc1 next-20201030]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Luo-Jiaxing/Introduce-a-new-helper-marco-DEFINE_SHOW_STORE_ATTRIBUTE-at-seq_file-c/20201030-165139
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/d38ab37c23ac876ce2ecb40c13d4a0697c7462ae
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Luo-Jiaxing/Introduce-a-new-helper-marco-DEFINE_SHOW_STORE_ATTRIBUTE-at-seq_file-c/20201030-165139
git checkout d38ab37c23ac876ce2ecb40c13d4a0697c7462ae
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/scsi/qla2xxx/qla_dfs.c: In function 'qla2x00_dfs_setup':
>> drivers/scsi/qla2xxx/qla_dfs.c:558:32: error: 'qla_dfs_naqp_ops' undeclared (first use in this function); did you mean 'qla_dfs_naqp_fops'?
558 | 0400, ha->dfs_dir, vha, &qla_dfs_naqp_ops);
| ^~~~~~~~~~~~~~~~
| qla_dfs_naqp_fops
drivers/scsi/qla2xxx/qla_dfs.c:558:32: note: each undeclared identifier is reported only once for each function it appears in
In file included from include/scsi/scsi_host.h:10,
from drivers/scsi/qla2xxx/qla_def.h:30,
from drivers/scsi/qla2xxx/qla_dfs.c:6:
At top level:
drivers/scsi/qla2xxx/qla_dfs.c:512:29: warning: 'qla_dfs_naqp_fops' defined but not used [-Wunused-const-variable=]
512 | DEFINE_SHOW_STORE_ATTRIBUTE(qla_dfs_naqp);
| ^~~~~~~~~~~~
include/linux/seq_file.h:200:37: note: in definition of macro 'DEFINE_SHOW_STORE_ATTRIBUTE'
200 | static const struct file_operations __name ## _fops = { \
| ^~~~~~
vim +558 drivers/scsi/qla2xxx/qla_dfs.c
513
514 int
515 qla2x00_dfs_setup(scsi_qla_host_t *vha)
516 {
517 struct qla_hw_data *ha = vha->hw;
518
519 if (!IS_QLA25XX(ha) && !IS_QLA81XX(ha) && !IS_QLA83XX(ha) &&
520 !IS_QLA27XX(ha) && !IS_QLA28XX(ha))
521 goto out;
522 if (!ha->fce)
523 goto out;
524
525 if (qla2x00_dfs_root)
526 goto create_dir;
527
528 atomic_set(&qla2x00_dfs_root_count, 0);
529 qla2x00_dfs_root = debugfs_create_dir(QLA2XXX_DRIVER_NAME, NULL);
530
531 create_dir:
532 if (ha->dfs_dir)
533 goto create_nodes;
534
535 mutex_init(&ha->fce_mutex);
536 ha->dfs_dir = debugfs_create_dir(vha->host_str, qla2x00_dfs_root);
537
538 atomic_inc(&qla2x00_dfs_root_count);
539
540 create_nodes:
541 ha->dfs_fw_resource_cnt = debugfs_create_file("fw_resource_count",
542 S_IRUSR, ha->dfs_dir, vha, &qla_dfs_fw_resource_cnt_fops);
543
544 ha->dfs_tgt_counters = debugfs_create_file("tgt_counters", S_IRUSR,
545 ha->dfs_dir, vha, &qla_dfs_tgt_counters_fops);
546
547 ha->tgt.dfs_tgt_port_database = debugfs_create_file("tgt_port_database",
548 S_IRUSR, ha->dfs_dir, vha, &qla2x00_dfs_tgt_port_database_fops);
549
550 ha->dfs_fce = debugfs_create_file("fce", S_IRUSR, ha->dfs_dir, vha,
551 &dfs_fce_ops);
552
553 ha->tgt.dfs_tgt_sess = debugfs_create_file("tgt_sess",
554 S_IRUSR, ha->dfs_dir, vha, &qla2x00_dfs_tgt_sess_fops);
555
556 if (IS_QLA27XX(ha) || IS_QLA83XX(ha) || IS_QLA28XX(ha)) {
557 ha->tgt.dfs_naqp = debugfs_create_file("naqp",
> 558 0400, ha->dfs_dir, vha, &qla_dfs_naqp_ops);
559 if (!ha->tgt.dfs_naqp) {
560 ql_log(ql_log_warn, vha, 0xd011,
561 "Unable to create debugFS naqp node.\n");
562 goto out;
563 }
564 }
565 vha->dfs_rport_root = debugfs_create_dir("rports", ha->dfs_dir);
566 if (!vha->dfs_rport_root) {
567 ql_log(ql_log_warn, vha, 0xd012,
568 "Unable to create debugFS rports node.\n");
569 goto out;
570 }
571 out:
572 return 0;
573 }
574
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 45913 bytes --]
next prev parent reply other threads:[~2020-10-31 8:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 8:31 [PATCH v2 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c Luo Jiaxing
2020-10-30 8:31 ` [PATCH v2 1/5] seq_file: Introduce DEFINE_SHOW_STORE_ATTRIBUTE() helper macro Luo Jiaxing
2020-10-30 8:31 ` [PATCH v2 2/5] scsi: hisi_sas: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs Luo Jiaxing
2020-10-30 8:32 ` [PATCH v2 3/5] scsi: qla2xxx: " Luo Jiaxing
2020-10-31 8:45 ` kernel test robot [this message]
2020-10-30 8:32 ` [PATCH v2 4/5] usb: dwc3: debugfs: Introduce DEFINE_SHOW_STORE_ATTRIBUTE Luo Jiaxing
2020-10-30 8:59 ` Felipe Balbi
2020-10-30 8:32 ` [PATCH v2 5/5] drm/i915/display: Introduce DEFINE_SHOW_STORE_ATTRIBUTE for debugfs Luo Jiaxing
2020-10-31 11:06 ` kernel test robot
2020-10-30 8:44 ` [PATCH v2 0/5] Introduce a new helper marco DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c Greg KH
2020-11-03 8:19 ` luojiaxing
2020-11-03 8:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202010311606.0Cn21JYx-lkp@intel.com \
--to=lkp@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=himanshu.madhani@cavium.com \
--cc=john.garry@huawei.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luojiaxing@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=uma.shankar@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox