From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10189C388F2 for ; Mon, 2 Nov 2020 11:09:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4A5A223BE for ; Mon, 2 Nov 2020 11:09:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SFTaJqUZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728444AbgKBLJW (ORCPT ); Mon, 2 Nov 2020 06:09:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728288AbgKBLJW (ORCPT ); Mon, 2 Nov 2020 06:09:22 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 906C2C0617A6 for ; Mon, 2 Nov 2020 03:09:20 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id x7so14104394wrl.3 for ; Mon, 02 Nov 2020 03:09:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=VNKBzuaah0h5Gb4hoIVZS3da51nQlrhYLCe3rboP11A=; b=SFTaJqUZtfkkrRI+Q9PY7VNO+a17R1kSjOtcGWcaK+CHErqUB/F2Sa3e/th8FMVcft TmgOCOTjq94XbgaUawLyPonyp5k6zXmfsTXV2c5U2H+oduVvMBHQfZoavcR4nCSVOAxY e9miCE9Iipq2MYWzeP+MDbIykjcYJY+WAAjOiKwHs2xr6UcrxbOO0I4ouSqA68j46mYC azb5mdF9wHULmZ2Cz6u54K2cSvx11STFdyPcDl9bInHXHq70Q98O+NKEk1Fq5YRZnsyK jacisaqaE9vTEUxs00HqwMo7MjuVoK8RkPC2yy5gcPU41D7lRiAA0z6d6utzoX9PXCjd w/bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=VNKBzuaah0h5Gb4hoIVZS3da51nQlrhYLCe3rboP11A=; b=IirRacX0UQcMjKfy87RSgE0fICBHO6GV1fQzKnTj6bpIN43bZR6eQpdoXmi5i0y1uq Yxkjj1ONiEYHF2rsiKsq998OMU10bOyPG/cXXlbVjUd8Q3f6vCKcgKFC6U0J488ACZdS qxtv88S1J4HDpNCauRujJDgem69ROjH5JmZFXR3rTk6mR359VnkDraQErFph6luOyCHN fViCW/QsYdDaRycSvV7reFvwsLJx2C7TOh8+MnIDB1++KR9HHpG8KkelIIb/pYzgv2GW iUtbKAbHwimatYiOD0vStdA8tSdLCtoQKOZUzVNLQjgOYhfYA5tYPGNkMuqOHbIW5V4m njPg== X-Gm-Message-State: AOAM531kDmG4gbFsiSmbcluI2MZM1TdIWzuOlF00REI29G2zefb4/2X2 N1KAaIrsmv+/nWeGuIXPDKIRMg== X-Google-Smtp-Source: ABdhPJxNCPU3ugtaw5SbDq9bRqIQsbfrQpZvvzXXHChVJFEpTyYgy/+pQ1unhh72pfJOI5cuZzTiTw== X-Received: by 2002:adf:df91:: with SMTP id z17mr18923542wrl.379.1604315359142; Mon, 02 Nov 2020 03:09:19 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id y185sm14706772wmb.29.2020.11.02.03.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:09:18 -0800 (PST) Date: Mon, 2 Nov 2020 11:09:16 +0000 From: Lee Jones To: Daniel Vetter Cc: Greg KH , Peilin Ye , Linux ARM , Linux Kernel Mailing List , stable , Russell King Subject: Re: [PATCH 1/1] Fonts: font_acorn_8x8: Replace discarded const qualifier Message-ID: <20201102110916.GK4127@dell> References: <20201030181822.570402-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Nov 2020, Daniel Vetter wrote: > On Fri, Oct 30, 2020 at 7:18 PM Lee Jones wrote: > > > > Commit 09e5b3fd5672 ("Fonts: Support FONT_EXTRA_WORDS macros for > > built-in fonts") introduced the following error when building > > rpc_defconfig (only this build appears to be affected): > > > > `acorndata_8x8' referenced in section `.text' of arch/arm/boot/compressed/ll_char_wr.o: > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > `acorndata_8x8' referenced in section `.data.rel.ro' of arch/arm/boot/compressed/font.o: > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > make[3]: *** [/scratch/linux/arch/arm/boot/compressed/Makefile:191: arch/arm/boot/compressed/vmlinux] Error 1 > > make[2]: *** [/scratch/linux/arch/arm/boot/Makefile:61: arch/arm/boot/compressed/vmlinux] Error 2 > > make[1]: *** [/scratch/linux/arch/arm/Makefile:317: zImage] Error 2 > > > > The .data section is discarded at link time. Reinstating > > acorndata_8x8 as const ensures it is still available after linking. > > > > Cc: > > Cc: Russell King > > Signed-off-by: Lee Jones > > Shouldn't we add the const to all of them, for consistency? The thought did cross my mind. However, I do not see any further issues which need addressing. Nor do I have any visibility into what issues may be caused by doing so. The only thing I know for sure is that this patch fixes the compile error pertained to in the commit message, and I'd like for this fix to be as atomic as possible, as it's designed to be routed through the Stable/LTS trees. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog