From: Vladimir Oltean <olteanv@gmail.com>
To: Qiang Zhao <qiang.zhao@nxp.com>
Cc: "broonie@kernel.org" <broonie@kernel.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference
Date: Mon, 2 Nov 2020 13:17:29 +0200 [thread overview]
Message-ID: <20201102111729.psxu6cx2mccbtra2@skbuf> (raw)
In-Reply-To: <VE1PR04MB67686E6B184C4EC4076172AE91100@VE1PR04MB6768.eurprd04.prod.outlook.com>
On Mon, Nov 02, 2020 at 02:19:28AM +0000, Qiang Zhao wrote:
> How about it looks like below:
>
> spi: fsl-dspi: fix wrong pointer in suspend/resume
>
> Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in
> remove path"), this driver causes a "NULL pointer dereference"
> in dspi_suspend/resume.
> This is because since this commit, the drivers private data point to
> "dspi" instead of "ctlr", the codes in suspend and resume func were
> not modified correspondly.
Looks ok.
next prev parent reply other threads:[~2020-11-02 11:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 8:40 [PATCH] spi: fsl-dspi: fix NULL pointer dereference Qiang Zhao
2020-10-29 11:03 ` Vladimir Oltean
2020-10-30 2:04 ` Qiang Zhao
2020-10-30 13:14 ` Vladimir Oltean
2020-10-30 13:02 ` Mark Brown
2020-11-02 2:01 ` Qiang Zhao
2020-10-30 13:18 ` Vladimir Oltean
2020-11-02 2:19 ` Qiang Zhao
2020-11-02 11:17 ` Vladimir Oltean [this message]
2020-11-04 20:43 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2020-09-27 22:43 Michael Walle
2020-09-27 23:27 ` Vladimir Oltean
2020-09-28 7:29 ` Krzysztof Kozlowski
2020-09-28 7:36 ` Krzysztof Kozlowski
2020-09-28 7:46 ` Michael Walle
2020-09-28 8:12 ` Krzysztof Kozlowski
2020-09-28 8:04 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102111729.psxu6cx2mccbtra2@skbuf \
--to=olteanv@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=qiang.zhao@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox