[linux-platform-drivers-x86:for-next 7/7] drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:38:23: sparse: sparse: symbol 'po_is_pass_set' was not declared. Should it be

[linux-platform-drivers-x86:for-next 7/7] drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:38:23: sparse: sparse: symbol 'po_is_pass_set' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2327 bytes --]

tree:   git://git.infradead.org/linux-platform-drivers-x86 for-next
head:   e8a60aa7404bfef37705da5607c97737073ac38d
commit: e8a60aa7404bfef37705da5607c97737073ac38d [7/7] platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems
config: i386-randconfig-s001-20201101 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-76-gf680124b-dirty
        git remote add linux-platform-drivers-x86 git://git.infradead.org/linux-platform-drivers-x86
        git fetch --no-tags linux-platform-drivers-x86 for-next
        git checkout e8a60aa7404bfef37705da5607c97737073ac38d
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:38:23: sparse: sparse: symbol 'po_is_pass_set' was not declared. Should it be static?
>> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:70:23: sparse: sparse: symbol 'po_current_password' was not declared. Should it be static?
>> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:99:23: sparse: sparse: symbol 'po_new_password' was not declared. Should it be static?
>> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:103:23: sparse: sparse: symbol 'po_min_pass_length' was not declared. Should it be static?
>> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:107:23: sparse: sparse: symbol 'po_max_pass_length' was not declared. Should it be static?
>> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:116:23: sparse: sparse: symbol 'po_mechanism' was not declared. Should it be static?
>> drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c:129:23: sparse: sparse: symbol 'po_role' was not declared. Should it be static?
--
>> drivers/platform/x86/dell-wmi-sysman/sysman.c:258:24: sparse: sparse: symbol 'wmi_sysman_kobj_sysfs_ops' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33906 bytes --]

[RFC PATCH linux-platform-drivers-x86] platform/x86: po_is_pass_set can be static

[kernel test robot]

Fixes: e8a60aa7404b ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Signed-off-by: kernel test robot <lkp@intel.com>
---
 passobj-attributes.c |   14 +++++++-------
 sysman.c             |    2 +-
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c b/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c
index e6199fb748a95a..81562b178c9cdd 100644
--- a/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c
+++ b/drivers/platform/x86/dell-wmi-sysman/passobj-attributes.c
@@ -35,7 +35,7 @@ static ssize_t is_enabled_show(struct kobject *kobj, struct kobj_attribute *attr
 	return ret;
 }
 
-struct kobj_attribute po_is_pass_set =
+static struct kobj_attribute po_is_pass_set =
 		__ATTR_RO(is_enabled);
 
 static ssize_t current_password_store(struct kobject *kobj,
@@ -67,7 +67,7 @@ static ssize_t current_password_store(struct kobject *kobj,
 	return count;
 }
 
-struct kobj_attribute po_current_password =
+static struct kobj_attribute po_current_password =
 		__ATTR_WO(current_password);
 
 static ssize_t new_password_store(struct kobject *kobj,
@@ -96,15 +96,15 @@ static ssize_t new_password_store(struct kobject *kobj,
 	return ret ? ret : count;
 }
 
-struct kobj_attribute po_new_password =
+static struct kobj_attribute po_new_password =
 		__ATTR_WO(new_password);
 
 attribute_n_property_show(min_password_length, po);
-struct kobj_attribute po_min_pass_length =
+static struct kobj_attribute po_min_pass_length =
 		__ATTR_RO(min_password_length);
 
 attribute_n_property_show(max_password_length, po);
-struct kobj_attribute po_max_pass_length =
+static struct kobj_attribute po_max_pass_length =
 		__ATTR_RO(max_password_length);
 
 static ssize_t mechanism_show(struct kobject *kobj, struct kobj_attribute *attr,
@@ -113,7 +113,7 @@ static ssize_t mechanism_show(struct kobject *kobj, struct kobj_attribute *attr,
 	return sprintf(buf, "password\n");
 }
 
-struct kobj_attribute po_mechanism =
+static struct kobj_attribute po_mechanism =
 	__ATTR_RO(mechanism);
 
 static ssize_t role_show(struct kobject *kobj, struct kobj_attribute *attr,
@@ -126,7 +126,7 @@ static ssize_t role_show(struct kobject *kobj, struct kobj_attribute *attr,
 	return -EIO;
 }
 
-struct kobj_attribute po_role =
+static struct kobj_attribute po_role =
 	__ATTR_RO(role);
 
 static struct attribute *po_attrs[] = {
diff --git a/drivers/platform/x86/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell-wmi-sysman/sysman.c
index 3842575a6c189f..c6862c3e9b491a 100644
--- a/drivers/platform/x86/dell-wmi-sysman/sysman.c
+++ b/drivers/platform/x86/dell-wmi-sysman/sysman.c
@@ -255,7 +255,7 @@ static ssize_t wmi_sysman_attr_store(struct kobject *kobj, struct attribute *att
 	return ret;
 }
 
-const struct sysfs_ops wmi_sysman_kobj_sysfs_ops = {
+static const struct sysfs_ops wmi_sysman_kobj_sysfs_ops = {
 	.show	= wmi_sysman_attr_show,
 	.store	= wmi_sysman_attr_store,
 };