From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 972D7C00A89 for ; Mon, 2 Nov 2020 12:35:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3865E2076E for ; Mon, 2 Nov 2020 12:35:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728684AbgKBMfC convert rfc822-to-8bit (ORCPT ); Mon, 2 Nov 2020 07:35:02 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:52879 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728359AbgKBMfC (ORCPT ); Mon, 2 Nov 2020 07:35:02 -0500 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id C780560002; Mon, 2 Nov 2020 12:34:58 +0000 (UTC) Date: Mon, 2 Nov 2020 13:34:57 +0100 From: Miquel Raynal To: Lee Jones Cc: vigneshr@ti.com, linux-kernel@vger.kernel.org, Robert Jarzmik , Richard Weinberger , linux-mtd@lists.infradead.org Subject: Re: [PATCH 04/23] mtd: devices: docg3: Fix kernel-doc 'bad line' and 'excessive doc' issues Message-ID: <20201102133457.7d2db57d@xps13> In-Reply-To: <20201102115406.1074327-5-lee.jones@linaro.org> References: <20201102115406.1074327-1-lee.jones@linaro.org> <20201102115406.1074327-5-lee.jones@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, Lee Jones wrote on Mon, 2 Nov 2020 11:53:47 +0000: > Fixes the following W=1 kernel build warning(s): > > drivers/mtd/devices/docg3.c:819: warning: bad line: > drivers/mtd/devices/docg3.c:1799: warning: Excess function parameter 'base' description in 'doc_probe_device' > > Cc: Robert Jarzmik > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: linux-mtd@lists.infradead.org > Signed-off-by: Lee Jones > --- > drivers/mtd/devices/docg3.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c > index a030792115bc2..5b0ae5ddad745 100644 > --- a/drivers/mtd/devices/docg3.c > +++ b/drivers/mtd/devices/docg3.c > @@ -816,7 +816,7 @@ static void doc_read_page_finish(struct docg3 *docg3) > > /** > * calc_block_sector - Calculate blocks, pages and ofs. > - > + * > * @from: offset in flash > * @block0: first plane block index calculated > * @block1: second plane block index calculated > @@ -1783,10 +1783,9 @@ static int __init doc_set_driver_info(int chip_id, struct mtd_info *mtd) > > /** > * doc_probe_device - Check if a device is available > - * @base: the io space where the device is probed > + * @cascade: the cascade of chips this devices will belong to > * @floor: the floor of the probed device > * @dev: the device > - * @cascade: the cascade of chips this devices will belong to > * > * Checks whether a device at the specified IO range, and floor is available. > * You also reorder the parameters in the kdoc which is not stated in the commit log. But that's nitpicking... Thanks, Miquèl