From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B2BAC388F2 for ; Mon, 2 Nov 2020 14:54:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1035E222EC for ; Mon, 2 Nov 2020 14:54:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="pg3oYsVQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726231AbgKBOyI (ORCPT ); Mon, 2 Nov 2020 09:54:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725974AbgKBOyH (ORCPT ); Mon, 2 Nov 2020 09:54:07 -0500 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82E54C061A04 for ; Mon, 2 Nov 2020 06:54:07 -0800 (PST) Received: by mail-qk1-x741.google.com with SMTP id 140so11675974qko.2 for ; Mon, 02 Nov 2020 06:54:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FF/JppJfxHL8ahJoJtPZ+p8h36QJk45Xb6vKWkqMYyw=; b=pg3oYsVQCcy7LuZa9ij1hYP+NbXJnYUJYqvAiWBgxzUX7RYZON9zygT2ZPp6F8QjqX ZebaplFHW2oBtkjQ7lAA0p4x7MxBLaBsmDqG7pXCTtCa1Wes9WpirKmT1NL69OmApInp +nt4h1EqBS7BIwpV1nZ5DpIkLmuDQP3XKHETORH2zXtib3kHz76R/hAXEQ1VZcCo9uJu 7i8M0Kkhiu9bUVGyDP/6zSlARAhN3+BBVYtV/9a6rjBlj3DC/Dk6AbsZ6LHoCiWp1KsE PRxGR0eduA8DXKx3CILnmoNBdmyCJy22nLpB7SxGCF6Y8UIdrItHGqNZvXoHjy3BTn7H SpIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FF/JppJfxHL8ahJoJtPZ+p8h36QJk45Xb6vKWkqMYyw=; b=Q89/SstsUZ9LRm8QuFeYHZ2SFi7GruZy0ShLzXlLAWOp9UacLRb3L5kU/ZOebjMTcW n5Zi3tXnuQOPX3pagnM6d4qiDGkAZBflMVqHV4NPwVv/nGD/jg1ZOIEQ321Wb335JpKZ vEfci3m13xjea15pab1//WYGjhqEW6XPCqG6678pW1u/SpFcdO1cFXh5Pdbynvk/OmHt qlghh6v7UINz2RABLoIhh0AqonHHdwsLOhkNp7RSLeOxBZlqohhhKyXjGoXh4fJ/3rMW PA3QEuhB1f/nHGQUZjaOMIEZ0rznEK+inE3IDvAHnkE99s7CIyUd2W77hiP24Th/IjSS AHFg== X-Gm-Message-State: AOAM531z90s3Hc3A3KQvfjzrAgIsrjIqpIBFKLlgu+RXE/D/WmK0/kUT LkyavDwTjL3V2or2BdeFzC1dOQ== X-Google-Smtp-Source: ABdhPJzVl4fH3qjWKemLmU0HXb0wx7FNPKcWuNz2M0gD0VEI3nqrp45sniYdi3oRbTSM12OlI88x+w== X-Received: by 2002:a37:e51:: with SMTP id 78mr15099002qko.191.1604328846819; Mon, 02 Nov 2020 06:54:06 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:2f6e]) by smtp.gmail.com with ESMTPSA id z69sm8211620qkb.7.2020.11.02.06.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 06:54:05 -0800 (PST) Date: Mon, 2 Nov 2020 09:52:20 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Alexander Duyck , Michal Hocko Subject: Re: [PATCH v20 12/20] mm/vmscan: remove lruvec reget in move_pages_to_lru Message-ID: <20201102145220.GE724984@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-13-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-13-git-send-email-alex.shi@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 06:44:57PM +0800, Alex Shi wrote: > A isolated page shouldn't be recharged by memcg since the memcg > migration isn't possible at the time. > So remove unnecessary regetting. > > Thanks to Alexander Duyck for pointing this out. > > Signed-off-by: Alex Shi > Acked-by: Hugh Dickins > Cc: Alexander Duyck > Cc: Andrew Morton > Cc: Konstantin Khlebnikov > Cc: Michal Hocko > Cc: Hugh Dickins > Cc: Johannes Weiner > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Cc: cgroups@vger.kernel.org Acked-by: Johannes Weiner A brief comment in the code could be good: all pages were isolated from the same lruvec (and isolation inhibits memcg migration).