From: Mel Gorman <mgorman@suse.de>
To: Phil Auld <pauld@redhat.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
Mel Gorman <mgorman@techsingularity.net>,
Peter Puhov <peter.puhov@linaro.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Robert Foley <robert.foley@linaro.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>,
Jirka Hladky <jhladky@redhat.com>
Subject: Re: [PATCH v1] sched/fair: update_pick_idlest() Select group with lowest group_util when idle_cpus are equal
Date: Mon, 2 Nov 2020 16:52:30 +0000 [thread overview]
Message-ID: <20201102165230.GF3306@suse.de> (raw)
In-Reply-To: <20201102144418.GB154641@lorien.usersys.redhat.com>
On Mon, Nov 02, 2020 at 09:44:18AM -0500, Phil Auld wrote:
> > I'm going to have a look at the regressions and see if patches that
> > have been queued for v5.10 or even more recent patch can help or if
> > the patch should be adjusted
> >
>
> Fwiw, we have pulled this in, along with some of the 5.10-rc1 fixes in this
> area and in the load balancing code.
>
I assume you mean a distro kernel but in this case, all the bisections
were vanilla mainline.
> We found some load balancing improvements and some minor overall perf
> gains in a few places, but generally did not see any difference from before
> the commit mentioned here.
>
> I'm wondering, Mel, if you have compared 5.10-rc1?
>
No, but it's queued now -- 5.9 vs 5.9-revert vs 5.10-rc2 vs
5.10-rc2-revert. It's only one machine queued but hopefully it'll
reproduce. Both 5.9 and 5.10 are being tested in case one of the changes
merged in 5.10 mask the problem. Ordinarily I would have checked first
but I'm backlogged so I took a report-first-test-later approach this
time around.
> We don't have everything though so it's possible something we have
> not pulled back is interacting with this patch, or we are missing something
> in our testing, or it's better with the later fixes in 5.10 or ...
> something else :)
>
Add userspace differences, core counts, CPU generation, volume of scheduler
changes with interactions, different implementations of tests, masking from
cpufreq changes, phase of the moon and just general plain old bad luck.
> I'll try to see if we can run some direct 5.8 - 5.9 tests like these.
>
That would be nice. While I often see false positive bisections for
performance bugs, the number of identical reports and different machines
made this more suspicious.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2020-11-02 16:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 12:59 [PATCH v1] sched/fair: update_pick_idlest() Select group with lowest group_util when idle_cpus are equal peter.puhov
2020-07-22 9:12 ` [tip: sched/core] " tip-bot2 for Peter Puhov
2020-11-02 10:50 ` [PATCH v1] " Mel Gorman
2020-11-02 11:06 ` Vincent Guittot
2020-11-02 14:44 ` Phil Auld
2020-11-02 16:52 ` Mel Gorman [this message]
2020-11-04 9:42 ` Mel Gorman
2020-11-04 10:06 ` Vincent Guittot
2020-11-04 10:47 ` Mel Gorman
2020-11-04 11:34 ` Vincent Guittot
2020-11-06 12:03 ` Mel Gorman
2020-11-06 13:33 ` Vincent Guittot
2020-11-06 16:00 ` Mel Gorman
2020-11-06 16:06 ` Vincent Guittot
2020-11-06 17:02 ` Mel Gorman
2020-11-09 15:24 ` Phil Auld
2020-11-09 15:38 ` Mel Gorman
2020-11-09 15:47 ` Phil Auld
2020-11-09 15:49 ` Vincent Guittot
2020-11-10 14:05 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102165230.GF3306@suse.de \
--to=mgorman@suse.de \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jhladky@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peter.puhov@linaro.org \
--cc=peterz@infradead.org \
--cc=robert.foley@linaro.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox