From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28BEC388F7 for ; Tue, 3 Nov 2020 08:43:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E74E22275 for ; Tue, 3 Nov 2020 08:43:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jcR1a7pY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727813AbgKCIno (ORCPT ); Tue, 3 Nov 2020 03:43:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726058AbgKCIno (ORCPT ); Tue, 3 Nov 2020 03:43:44 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F631C0617A6 for ; Tue, 3 Nov 2020 00:43:42 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id 205so4163398wma.4 for ; Tue, 03 Nov 2020 00:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4x5b3JzpvlcUe6sMCJAllWm7e4Nw8obUH53KK3bsNXQ=; b=jcR1a7pYDZzsooTxcfYT2w8r5eDoTyG7e4eVu8VGcW6tSdyDwPGyCMIxntldKhEInm 6IjxxeyWTGH/nEgKHwCNa8nxqqMfJqcCdSS3zb3IR4cfhDEctIWmnDsxsNwNPYFawopF ABrjqLGUAEVxowe9+F86xyNT3+i314dE4Bzhi866K+fIKvO/DQZwNqifsqRlJQXcNfKu E/TJMpF9/K21vTzrWN/Y72c4TwU4UAtftLPdUspGOILBUQjBVSnQZeeebQwW+s8imuFz PLA3zqMpbT181LBsYVjWD58SLdtQUngzGCy9s54xPE0A0P90UVotPRt+oSoUKj6H2WBq 0Euw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=4x5b3JzpvlcUe6sMCJAllWm7e4Nw8obUH53KK3bsNXQ=; b=gmoW8HhKD36rBvkN/xfAIxstihrGSpjfExnDU8wCb9ekmcmbZoMAhoset6Z5a58Iuc AFcJsnAB8arigVARk1ZlhZkq906crEGe3R6RVAH9OOrcxYPgNoZglR3eQmFR2UZw1aKk d2JmHzDkUwgJmcUlO9I/PIFJsMOyChQrbyM9UC8NqmzwjW3SoIO2aKpYYNqrg79lT28E khCpWi7FyOVWhTHr46Q0DdjBssiU6Ej+yREB0jQGf18RYQATolQz0KqooF5zItZ6UmuC 4JrhJEox4WNe4yQNyI7bm37kE87zYlLgF7xpKI9bq3nu9MM+ZPpEmH8shmQvZqDdMiFA Rwsw== X-Gm-Message-State: AOAM530aBtUSfsWJsbl42rr60/UZlDhQJg58O+mQuuG5deX48X+y4n2W JWUx3/A9T91gsRGNLY38XbVdZg== X-Google-Smtp-Source: ABdhPJy0Kp8A3oC5BQ3pC1rLkWiUJiXVEpp6RYgMd0SdiY1r/HBSkq66UYmo0XV8wKtnzhY+Z2ZZEg== X-Received: by 2002:a1c:9d02:: with SMTP id g2mr2398444wme.110.1604393021038; Tue, 03 Nov 2020 00:43:41 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id k81sm2443125wma.2.2020.11.03.00.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 00:43:40 -0800 (PST) Date: Tue, 3 Nov 2020 08:43:38 +0000 From: Lee Jones To: AceLan Kao Cc: Shihlun Lin , Mauro Carvalho Chehab , "David S . Miller" , Rob Herring , "Linux-Kernel@Vger. Kernel. Org" , devicetree@vger.kernel.org, Campion Kang Subject: Re: [PATCH v3 5/6] mfd: ahc1ec0-hwmon: Add sub-device hwmon for Advantech embedded controller Message-ID: <20201103084338.GI4488@dell> References: <20201029100613.25789-1-shihlun.lin@advantech.com.tw> <20201029100613.25789-5-shihlun.lin@advantech.com.tw> <20201029131419.GA4127@dell> <20201103084053.GH4488@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201103084053.GH4488@dell> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 03 Nov 2020, Lee Jones wrote: > On Tue, 03 Nov 2020, AceLan Kao wrote: > > > Hi Lee, > > > > One question for you. > > > > Lee Jones 於 2020年10月29日 週四 下午9:14寫道： > > > > > > On Thu, 29 Oct 2020, Shihlun Lin wrote: > > > > > > > This is one of sub-device driver for Advantech embedded controller > > > > AHC1EC0. This driver provides sysfs ABI for Advantech related > > > > applications to monitor the system status. > > > > > > > > Signed-off-by: Shihlun Lin > > > > Reported-by: kernel test robot > > > > > > LKP reported that your driver needed upstreaming? > > > > > > I'm confused! > > > > > > > --- > > > > drivers/mfd/Kconfig | 8 + > > > > drivers/mfd/Makefile | 1 + > > > > drivers/mfd/ahc1ec0-hwmon.c | 1514 +++++++++++++++++++++++++++++++++++ > > > > > > This obviously belongs in drivers/hwmon. > > > > > > > 3 files changed, 1523 insertions(+) > > > > create mode 100644 drivers/mfd/ahc1ec0-hwmon.c > > > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > > index 965bcafbe5b2..52ca49b211fc 100644 > > > > --- a/drivers/mfd/Kconfig > > > > +++ b/drivers/mfd/Kconfig > > > > @@ -2175,5 +2175,13 @@ config MFD_AHC1EC0 > > > > provides expose functions for sub-devices to read/write the value > > > > to embedded controller. > > > > > > > > +config MFD_AHC1EC0_HWMON > > > > + tristate "Advantech EC Hareware Monitor Function" > > > > + depends on MFD_AHC1EC0 > > > > + help > > > > + This is sub-device for Advantech embedded controller AHC1EC0. This > > > > + driver provides the sysfs attribues for applications to monitor > > > > + the system status. > > > > + > > > > endmenu > > > > endif > > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > > > index 80a9a2bdc3ba..eb645db817b5 100644 > > > > --- a/drivers/mfd/Makefile > > > > +++ b/drivers/mfd/Makefile > > > > @@ -269,3 +269,4 @@ obj-$(CONFIG_MFD_SIMPLE_MFD_I2C) += simple-mfd-i2c.o > > > > obj-$(CONFIG_MFD_INTEL_M10_BMC) += intel-m10-bmc.o > > > > > > > > obj-$(CONFIG_MFD_AHC1EC0) += ahc1ec0.o > > > > +obj-$(CONFIG_MFD_AHC1EC0_HWMON) += ahc1ec0-hwmon.o > > > > diff --git a/drivers/mfd/ahc1ec0-hwmon.c b/drivers/mfd/ahc1ec0-hwmon.c > > > > new file mode 100644 > > > > index 000000000000..3e493b040b4a > > > > --- /dev/null > > > > +++ b/drivers/mfd/ahc1ec0-hwmon.c > > > > @@ -0,0 +1,1514 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-only > > > > +/***************************************************************************** > > > > + * Copyright (c) 2018, Advantech Automation Corp. > > > > > > You can't just lift a whole driver from downstream code and send it to > > > the mailing list as-is. > > Could you elaborate more about which part should be fixed, and how it > > should look like? > > Frankly, no. > > I would expect a contributor of a several thousand line patch-set to > at least read the documentation and adhere to it prior to anyone > conducting a full review. Simply plucking a very old driver set from > a BSP kernel and dumping it on the upstream mailing list is not the > way to gain the right kind of attention. > > At the very least (this is not an exhaustive list); > > - all of the copyrights need to be up-to-date > - the drivers need to be located in their correct subsystems > - any internal references/comment headers need to be removed > - licences should be compatible with upstreaming > - hacks removed > - builds without errors or warnings > - checkpatch.pl passed > - submission should tick all of the boxes in SubmittingPatches > - removal of changelogs/versions > - this is the first version as far as the kernel is concerned Also spell-check. Literally the 2nd line: config MFD_AHC1EC0_HWMON tristate "Advantech EC Hareware Monitor Function" I don't know what Hareware is, but is sounds fast! ;) > > > > + * THIS IS AN UNPUBLISHED WORK CONTAINING CONFIDENTIAL AND PROPRIETARY > > > > + * INFORMATION WHICH IS THE PROPERTY OF ADVANTECH AUTOMATION CORP. > > > > + * > > > > + * ANY DISCLOSURE, USE, OR REPRODUCTION, WITHOUT WRITTEN AUTHORIZATION FROM > > > > + * ADVANTECH AUTOMATION CORP., IS STRICTLY PROHIBITED. > > > > + ***************************************************************************** > > > > > > This warning is in contradiction to the licence you are proposing. > > > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog