From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763BFC2D0A3 for ; Tue, 3 Nov 2020 08:44:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 241FD223BF for ; Tue, 3 Nov 2020 08:44:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="D/tNDQgc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727862AbgKCIo6 (ORCPT ); Tue, 3 Nov 2020 03:44:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbgKCIo5 (ORCPT ); Tue, 3 Nov 2020 03:44:57 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42042C0617A6 for ; Tue, 3 Nov 2020 00:44:57 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id p22so11857490wmg.3 for ; Tue, 03 Nov 2020 00:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=5/WOZHBmz3EBH3+eCAudlxs+DpqVNBs0AEAQtQF3C0g=; b=D/tNDQgcgZFGx9ufo0kyX0caMAMLaJEDmZZar9aTdI+nTB9DiJS3uimqhClmlkv92N PTN2NgpbaMKPWw/6zwTa4o6wsGYC/QudW8o05fr9c9y3HXkac7wJD+cThiHUxfFGrXIO lUhf0X7R1ls37PqrduWqkrZSUYXq18N4k98mN4fSuvA1l9NqRyBlHyIX4w7jsaUPNOVi gzgTPFzgW9XrKjyCg5rrx4StYlo9blEfSZJUyBQOCS1jNCUaRhhK0oqP9o/MmzZUToJ1 7v/Q5bkbJnDFrkGirDBHFrCtnRwV/tMNjQbYRD6NwJtOgvcw2Exk4tZ6mORjpINR9Os8 IJmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=5/WOZHBmz3EBH3+eCAudlxs+DpqVNBs0AEAQtQF3C0g=; b=cN4Hw9MY1k6u9MBX77wUB1CMtQufxJ1HcAcy4sa+H5yKg8UQWzhojX0NPWV+Bir667 C1dsKjZWmxEPHvtigbf1V16Ceztsc4fDPr4GakmCW7mPDQVnvtiFyzrydYkawf+46Dv2 DUdCASJEsLQS43wYTUKHc6vyPf8AESowVoXll+CvBPjrpM7GxvOGYc3PsN1UGYTN1Lwm 0gjIBHKBo0ZcXSXGUHcxyKPDisUXJ/IgbxNyiutDvPF3gyP/Kb7aWgMs+fF6FRrOAhna 9TSVJEJVzLxtPHyzmzvOIGn8MW02vV/kfKMwSPdcxnDucYiPdU/F/wgQH7P2iNZi+74i REvw== X-Gm-Message-State: AOAM533lTmYHQuVJXbxfgIzBaQDgMelgsXfJ3yzRY+8YeI1EIDozwTcL 66bCW7PhEiA+5a5WfgxBdWEYRBsaU4LauXIy X-Google-Smtp-Source: ABdhPJz8fx8VQuhvfzqJtAKCb4y9SD7Xt0brjcuk8KmNJ2RedYCauy94oAfQvnsKQQSqF2yMZLA6tA== X-Received: by 2002:a7b:c4c3:: with SMTP id g3mr2313652wmk.65.1604393096021; Tue, 03 Nov 2020 00:44:56 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id c17sm2084243wml.14.2020.11.03.00.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 00:44:55 -0800 (PST) Date: Tue, 3 Nov 2020 08:44:53 +0000 From: Lee Jones To: Brian Norris Cc: Kalle Valo , Linux Kernel , Yan-Hsuan Chuang , "David S. Miller" , Jakub Kicinski , linux-wireless , "" Subject: Re: [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown Message-ID: <20201103084453.GJ4488@dell> References: <20201102112410.1049272-1-lee.jones@linaro.org> <20201102112410.1049272-42-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 02 Nov 2020, Brian Norris wrote: > On Mon, Nov 2, 2020 at 3:25 AM Lee Jones wrote: > > --- a/drivers/net/wireless/realtek/rtw88/pci.h > > +++ b/drivers/net/wireless/realtek/rtw88/pci.h > > @@ -212,6 +212,10 @@ struct rtw_pci { > > void __iomem *mmap; > > }; > > > > +int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id); > > +void rtw_pci_remove(struct pci_dev *pdev); > > +void rtw_pci_shutdown(struct pci_dev *pdev); > > + > > > > These definitions are already in 4 other header files: > > drivers/net/wireless/realtek/rtw88/rtw8723de.h > drivers/net/wireless/realtek/rtw88/rtw8821ce.h > drivers/net/wireless/realtek/rtw88/rtw8822be.h > drivers/net/wireless/realtek/rtw88/rtw8822ce.h > > Seems like you should be moving them, not just adding yet another duplicate. I followed the current convention. Happy to optimise if that's what is required. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog