From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48FE2C2D0A3 for ; Tue, 3 Nov 2020 09:14:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A06622400 for ; Tue, 3 Nov 2020 09:14:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604394890; bh=ZHBZOejCjX5l8sZRwuQR75aiAkvpCacnS9a7dm3ZHWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NRilaoe1tkjJJqrERefBkTHGfEmVI3ltLlcxrLIq8/aYBpgs24DDQ9G2jTlKPI/lp 3n+ZvGBM9ppV/qcthvIywKXyZBf4HuTh3TEOWgKxOoLj5iUUXvM1SnjFxKM4tY66XP advV/Qc0Ws4pGV7JlcG9xbpZ/BnD/wJkm+aE1yL8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727263AbgKCJOt (ORCPT ); Tue, 3 Nov 2020 04:14:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:35416 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbgKCJOr (ORCPT ); Tue, 3 Nov 2020 04:14:47 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0CB8020756; Tue, 3 Nov 2020 09:14:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604394885; bh=ZHBZOejCjX5l8sZRwuQR75aiAkvpCacnS9a7dm3ZHWw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qln8MdI6DivkRV8z0NNzzjlNCxVzjVdA/Fv1NgjVip/n/1gFGnqFFvPb71GuAnUIO /2eNbcs3wGdBPupCY+nPbaFzvLuxEUzYibz1rSSFzK875xRQ0sASb7T2390zB6JrJ9 /8V+j5a9jQGnLDsnL73G32hmgIebDkvEIp3AO60Y= Date: Tue, 3 Nov 2020 10:15:38 +0100 From: Greg KH To: Daniel Vetter Cc: Lee Jones , Peilin Ye , Russell King - ARM Linux , Linux ARM , Linux Kernel Mailing List , stable Subject: Re: [PATCH v2 1/1] Fonts: Replace discarded const qualifier Message-ID: <20201103091538.GA2663113@kroah.com> References: <20201030181822.570402-1-lee.jones@linaro.org> <20201102183242.2031659-1-yepeilin.cs@gmail.com> <20201103085324.GL4488@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 03, 2020 at 09:58:18AM +0100, Daniel Vetter wrote: > On Tue, Nov 3, 2020 at 9:53 AM Lee Jones wrote: > > > > On Mon, 02 Nov 2020, Peilin Ye wrote: > > > > > From: Lee Jones > > > > > > Commit 6735b4632def ("Fonts: Support FONT_EXTRA_WORDS macros for built-in > > > fonts") introduced the following error when building rpc_defconfig (only > > > this build appears to be affected): > > > > > > `acorndata_8x8' referenced in section `.text' of arch/arm/boot/compressed/ll_char_wr.o: > > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > > `acorndata_8x8' referenced in section `.data.rel.ro' of arch/arm/boot/compressed/font.o: > > > defined in discarded section `.data' of arch/arm/boot/compressed/font.o > > > make[3]: *** [/scratch/linux/arch/arm/boot/compressed/Makefile:191: arch/arm/boot/compressed/vmlinux] Error 1 > > > make[2]: *** [/scratch/linux/arch/arm/boot/Makefile:61: arch/arm/boot/compressed/vmlinux] Error 2 > > > make[1]: *** [/scratch/linux/arch/arm/Makefile:317: zImage] Error 2 > > > > > > The .data section is discarded at link time. Reinstating acorndata_8x8 as > > > const ensures it is still available after linking. Do the same for the > > > other 12 built-in fonts as well, for consistency purposes. > > > > > > Cc: > > > Cc: Russell King > > > Fixes: 6735b4632def ("Fonts: Support FONT_EXTRA_WORDS macros for built-in fonts") > > > Signed-off-by: Lee Jones > > > Co-developed-by: Peilin Ye > > > Signed-off-by: Peilin Ye > > > --- > > > Changes in v2: > > > - Fix commit ID to 6735b4632def in commit message (Russell King > > > ) > > > - Add `const` back for all 13 built-in fonts (Daniel Vetter > > > ) > > > - Add a Fixes: tag > > > > > > lib/fonts/font_10x18.c | 2 +- > > > lib/fonts/font_6x10.c | 2 +- > > > lib/fonts/font_6x11.c | 2 +- > > > lib/fonts/font_6x8.c | 2 +- > > > lib/fonts/font_7x14.c | 2 +- > > > lib/fonts/font_8x16.c | 2 +- > > > lib/fonts/font_8x8.c | 2 +- > > > lib/fonts/font_acorn_8x8.c | 2 +- > > > lib/fonts/font_mini_4x6.c | 2 +- > > > lib/fonts/font_pearl_8x8.c | 2 +- > > > lib/fonts/font_sun12x22.c | 2 +- > > > lib/fonts/font_sun8x16.c | 2 +- > > > lib/fonts/font_ter16x32.c | 2 +- > > > 13 files changed, 13 insertions(+), 13 deletions(-) > > > > LGTM. > > > > Thanks for keeping my authorship. Much appreciated. > > Should I stuff this into drm-misc-fixes? Or will someone else pick > this up? Greg? > > I guess drm-misc-fixes might be easiest since there's a bunch of other > fbcon/font stuff in the queue in drm-misc from Peilin. You can take it: Reviewed-by: Greg Kroah-Hartman