From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Stephen Boyd <sboyd@kernel.org>
Cc: lkp@intel.com, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Arnd Bergmann <arnd@arndb.de>
Subject: [kbuild] sound/soc/codecs/wcd934x.c:1571:9: warning: Identical condition 'ret', second condition is always false
Date: Tue, 3 Nov 2020 13:57:13 +0300 [thread overview]
Message-ID: <20201103105713.GC18329@kadam> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b7cbaf59f62f8ab8f157698f9e31642bff525bd0
commit: bbd7ffdbef6888459f301c5889f3b14ada38b913 clk: Allow the common clk framework to be selectable
compiler: ia64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
>> sound/soc/codecs/wcd934x.c:1571:9: warning: Identical condition 'ret', second condition is always false [identicalConditionAfterEarlyExit]
return ret;
^
sound/soc/codecs/wcd934x.c:1568:6: note: first condition
if (ret)
^
sound/soc/codecs/wcd934x.c:1571:9: note: second condition
return ret;
^
vim +/ret +1571 sound/soc/codecs/wcd934x.c
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1561
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1562 ret = wcd934x_set_prim_interpolator_rate(dai, (u8)rate_val,
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1563 sample_rate);
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1564 if (ret)
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1565 return ret;
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1566 ret = wcd934x_set_mix_interpolator_rate(dai, (u8)rate_val,
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1567 sample_rate);
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1568 if (ret)
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1569 return ret;
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1570
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 @1571 return ret;
^^^^^^^^^^^
Just "return 0;"
a61f3b4f476eceb Srinivas Kandagatla 2019-12-19 1572 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
reply other threads:[~2020-11-03 10:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103105713.GC18329@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox