From: Dave Martin <Dave.Martin@arm.com>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Andre Przywara <Andre.Przywara@arm.com>,
James Clark <James.Clark@arm.com>, Al Grant <Al.Grant@arm.com>,
Wei Li <liwei391@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 20/21] perf arm_spe: Decode memory tagging properties
Date: Tue, 3 Nov 2020 12:14:07 +0000 [thread overview]
Message-ID: <20201103121407.GN6882@arm.com> (raw)
In-Reply-To: <20201103065101.GE13232@leoy-ThinkPad-X240s>
On Tue, Nov 03, 2020 at 06:51:01AM +0000, Leo Yan wrote:
> On Mon, Nov 02, 2020 at 04:25:36PM +0000, Dave Martin wrote:
> > On Fri, Oct 30, 2020 at 02:57:23AM +0000, Leo Yan wrote:
> > > From: Andre Przywara <andre.przywara@arm.com>
> > >
> > > When SPE records a physical address, it can additionally tag the event
> > > with information from the Memory Tagging architecture extension.
> > >
> > > Decode the two additional fields in the SPE event payload.
> > >
> > > [leoy: Refined patch to use predefined macros]
> > >
> > > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> > > ---
> > > tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c | 6 +++++-
> > > tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h | 2 ++
> > > 2 files changed, 7 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> > > index 3fca65e9cbbf..9ec3057de86f 100644
> > > --- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> > > +++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
> > > @@ -371,6 +371,7 @@ static int arm_spe_pkt_desc_addr(const struct arm_spe_pkt *packet,
> > > char *buf, size_t buf_len)
> > > {
> > > int ns, el, idx = packet->index;
> > > + int ch, pat;
> > > u64 payload = packet->payload;
> > > int err = 0;
> > >
> > > @@ -388,9 +389,12 @@ static int arm_spe_pkt_desc_addr(const struct arm_spe_pkt *packet,
> > > "VA 0x%llx", payload);
> > > case SPE_ADDR_PKT_HDR_INDEX_DATA_PHYS:
> > > ns = !!SPE_ADDR_PKT_GET_NS(payload);
> > > + ch = !!SPE_ADDR_PKT_GET_CH(payload);
> > > + pat = SPE_ADDR_PKT_GET_PAT(payload);
> > > payload = SPE_ADDR_PKT_ADDR_GET_BYTES_0_6(payload);
> > > return arm_spe_pkt_snprintf(&err, &buf, &buf_len,
> > > - "PA 0x%llx ns=%d", payload, ns);
> > > + "PA 0x%llx ns=%d ch=%d, pat=%x",
> >
> > Nit: given that this data is all closely related, do we really want the
> > extra comma here?
>
> No reason for adding comma. Will remove it.
OK, I'm happy for my Reviewed-by to stand.
[...]
Cheers
---Dave
next prev parent reply other threads:[~2020-11-03 12:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 2:57 [PATCH v6 00/21] perf arm-spe: Refactor decoding & dumping flow Leo Yan
2020-10-30 2:57 ` [PATCH v6 01/21] perf arm-spe: Include bitops.h for BIT() macro Leo Yan
2020-10-30 2:57 ` [PATCH v6 02/21] perf arm-spe: Fix a typo in comment Leo Yan
2020-10-30 2:57 ` [PATCH v6 03/21] perf arm-spe: Refactor payload size calculation Leo Yan
2020-10-30 2:57 ` [PATCH v6 04/21] perf arm-spe: Refactor arm_spe_get_events() Leo Yan
2020-10-30 2:57 ` [PATCH v6 05/21] perf arm-spe: Fix packet length handling Leo Yan
2020-10-30 2:57 ` [PATCH v6 06/21] perf arm-spe: Refactor printing string to buffer Leo Yan
2020-11-02 15:50 ` André Przywara
2020-11-03 2:39 ` Leo Yan
2020-11-06 1:58 ` Leo Yan
2020-11-02 17:06 ` Dave Martin
2020-11-03 6:40 ` Leo Yan
2020-11-03 10:13 ` André Przywara
2020-11-03 12:13 ` Dave Martin
2020-11-04 8:29 ` Leo Yan
2020-10-30 2:57 ` [PATCH v6 07/21] perf arm-spe: Refactor packet header parsing Leo Yan
2020-10-30 2:57 ` [PATCH v6 08/21] perf arm-spe: Add new function arm_spe_pkt_desc_addr() Leo Yan
2020-10-30 2:57 ` [PATCH v6 09/21] perf arm-spe: Refactor address packet handling Leo Yan
2020-10-30 2:57 ` [PATCH v6 10/21] perf arm_spe: Fixup top byte for data virtual address Leo Yan
2020-10-30 2:57 ` [PATCH v6 11/21] perf arm-spe: Refactor context packet handling Leo Yan
2020-10-30 2:57 ` [PATCH v6 12/21] perf arm-spe: Add new function arm_spe_pkt_desc_counter() Leo Yan
2020-10-30 2:57 ` [PATCH v6 13/21] perf arm-spe: Refactor counter packet handling Leo Yan
2020-10-30 2:57 ` [PATCH v6 14/21] perf arm-spe: Add new function arm_spe_pkt_desc_event() Leo Yan
2020-10-30 2:57 ` [PATCH v6 15/21] perf arm-spe: Refactor event type handling Leo Yan
2020-10-30 2:57 ` [PATCH v6 16/21] perf arm-spe: Remove size condition checking for events Leo Yan
2020-10-30 2:57 ` [PATCH v6 17/21] perf arm-spe: Add new function arm_spe_pkt_desc_op_type() Leo Yan
2020-10-30 2:57 ` [PATCH v6 18/21] perf arm-spe: Refactor operation packet handling Leo Yan
2020-10-30 2:57 ` [PATCH v6 19/21] perf arm-spe: Add more sub classes for operation packet Leo Yan
2020-10-30 2:57 ` [PATCH v6 20/21] perf arm_spe: Decode memory tagging properties Leo Yan
2020-11-02 16:25 ` Dave Martin
2020-11-03 6:51 ` Leo Yan
2020-11-03 12:14 ` Dave Martin [this message]
2020-10-30 2:57 ` [PATCH v6 21/21] perf arm-spe: Add support for ARMv8.3-SPE Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103121407.GN6882@arm.com \
--to=dave.martin@arm.com \
--cc=Al.Grant@arm.com \
--cc=Andre.Przywara@arm.com \
--cc=James.Clark@arm.com \
--cc=Mark.Rutland@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).