From: kernel test robot <lkp@intel.com>
To: Ajye Huang <ajye.huang@gmail.com>, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
Mark Brown <broonie@kernel.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Patrick Lai <plai@codeaurora.org>,
Srinivasa Rao Mandadapu <srivasam@codeaurora.org>,
srinivas.kandagatla@linaro.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH v4 2/2] ASoC: qcom: sc7180: Modify machine driver for 2mic
Date: Tue, 3 Nov 2020 16:00:49 +0800 [thread overview]
Message-ID: <202011031520.ZAG5DNRC-lkp@intel.com> (raw)
In-Reply-To: <20201103025347.510940-3-ajye_huang@compal.corp-partner.google.com>
[-- Attachment #1: Type: text/plain, Size: 3975 bytes --]
Hi Ajye,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next]
[also build test WARNING on next-20201102]
[cannot apply to linus/master linux/master agross-msm/qcom/for-next v5.10-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Ajye-Huang/Modify-documentation-and-machine-driver-for-SC7180-sound-card/20201103-105632
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: arm64-randconfig-r016-20201103 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1fcd5d5655e29f85e12b402e32974f207cfedf32)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/355751174468ab4d64f549b169b6a9fdba0fbe1e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Ajye-Huang/Modify-documentation-and-machine-driver-for-SC7180-sound-card/20201103-105632
git checkout 355751174468ab4d64f549b169b6a9fdba0fbe1e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> sound/soc/qcom/sc7180.c:297:53: warning: format specifies type 'int' but the argument has type 'long' [-Wformat]
dev_err(&pdev->dev, "DMIC gpio failed err=%d\n", PTR_ERR(data->dmic_sel));
~~ ^~~~~~~~~~~~~~~~~~~~~~~
%ld
include/linux/dev_printk.h:112:32: note: expanded from macro 'dev_err'
_dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
1 warning generated.
vim +297 sound/soc/qcom/sc7180.c
268
269 static int sc7180_snd_platform_probe(struct platform_device *pdev)
270 {
271 struct snd_soc_card *card;
272 struct sc7180_snd_data *data;
273 struct device *dev = &pdev->dev;
274 int ret;
275
276 /* Allocate the private data */
277 data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
278 if (!data)
279 return -ENOMEM;
280
281 card = &data->card;
282 snd_soc_card_set_drvdata(card, data);
283
284 card->owner = THIS_MODULE;
285 card->driver_name = DRIVER_NAME;
286 card->dev = dev;
287 card->dapm_widgets = sc7180_snd_widgets;
288 card->num_dapm_widgets = ARRAY_SIZE(sc7180_snd_widgets);
289
290 if (of_property_read_bool(dev->of_node, "dmic-gpios")) {
291 card->dapm_widgets = sc7180_snd_dual_mic_widgets,
292 card->num_dapm_widgets = ARRAY_SIZE(sc7180_snd_dual_mic_widgets),
293 card->dapm_routes = sc7180_snd_dual_mic_audio_route,
294 card->num_dapm_routes = ARRAY_SIZE(sc7180_snd_dual_mic_audio_route),
295 data->dmic_sel = devm_gpiod_get(&pdev->dev, "dmic", GPIOD_OUT_LOW);
296 if (IS_ERR(data->dmic_sel)) {
> 297 dev_err(&pdev->dev, "DMIC gpio failed err=%d\n", PTR_ERR(data->dmic_sel));
298 return PTR_ERR(data->dmic_sel);
299 }
300 }
301
302 ret = qcom_snd_parse_of(card);
303 if (ret)
304 return ret;
305
306 sc7180_add_ops(card);
307
308 return devm_snd_soc_register_card(dev, card);
309 }
310
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 44613 bytes --]
prev parent reply other threads:[~2020-11-03 8:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 2:53 [PATCH v4 0/2] Modify documentation and machine driver for SC7180 sound card Ajye Huang
2020-11-03 2:53 ` [PATCH v4 1/2] ASoC: google: dt-bindings: modify machine bindings for two MICs case Ajye Huang
2020-11-03 7:00 ` Ajye Huang
2020-11-03 2:53 ` [PATCH v4 2/2] ASoC: qcom: sc7180: Modify machine driver for 2mic Ajye Huang
2020-11-03 3:48 ` Tzung-Bi Shih
2020-11-03 8:00 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011031520.ZAG5DNRC-lkp@intel.com \
--to=lkp@intel.com \
--cc=agross@kernel.org \
--cc=ajye.huang@gmail.com \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=srivasam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox