From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A72DC388F7 for ; Tue, 3 Nov 2020 21:13:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABE9B20757 for ; Tue, 3 Nov 2020 21:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437989; bh=cEYcqo0HfhMWwa15jk3JBkbvGR1AGq4Ir29tctpU3jU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DJZpGxq9vBm2gFT1OSrcUk4pE06CgbyvHm1dubuHT4vbln6M9pMRWT769DIQXTZe+ a0dNOx19oXQCcavzkRdNCAsbU9DZ25H5EggsHP1Wn8lS8o/10BaGiCVEl66n6/Lh5Z t0c5MpqAv5grZ14OlSAcsnfsRUsyPnKcygYT/yUs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389066AbgKCVMo (ORCPT ); Tue, 3 Nov 2020 16:12:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:55184 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389054AbgKCVMm (ORCPT ); Tue, 3 Nov 2020 16:12:42 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 46CE2206B5; Tue, 3 Nov 2020 21:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437960; bh=cEYcqo0HfhMWwa15jk3JBkbvGR1AGq4Ir29tctpU3jU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g/WHPx2CxUIE+IUyGiA0EF1FyvQU/zegmT5C7FKXUhV0IbJXmwYBtKBnDFJcTb6qC 6hq+DSWROR81Bx9nNeQLmyE6HXD4WrEi2/PS/ULLR4sDF6I8X9C+JUcOGS4RLyuxTD /djPnaTXiO9cUND3OERc8vP9oIgtFOGLvjX0jIVQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, jim@photojim.ca, Ben Hutchings , "Rafael J. Wysocki" Subject: [PATCH 4.14 067/125] ACPI / extlog: Check for RDMSR failure Date: Tue, 3 Nov 2020 21:37:24 +0100 Message-Id: <20201103203206.543556763@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203156.372184213@linuxfoundation.org> References: <20201103203156.372184213@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ben Hutchings commit 7cecb47f55e00282f972a1e0b09136c8cd938221 upstream. extlog_init() uses rdmsrl() to read an MSR, which on older CPUs provokes a error message at boot: unchecked MSR access error: RDMSR from 0x179 at rIP: 0xcd047307 (native_read_msr+0x7/0x40) Use rdmsrl_safe() instead, and return -ENODEV if it fails. Reported-by: jim@photojim.ca Cc: All applicable Signed-off-by: Ben Hutchings Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/acpi/acpi_extlog.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/acpi/acpi_extlog.c +++ b/drivers/acpi/acpi_extlog.c @@ -224,9 +224,9 @@ static int __init extlog_init(void) u64 cap; int rc; - rdmsrl(MSR_IA32_MCG_CAP, cap); - - if (!(cap & MCG_ELOG_P) || !extlog_get_l1addr()) + if (rdmsrl_safe(MSR_IA32_MCG_CAP, &cap) || + !(cap & MCG_ELOG_P) || + !extlog_get_l1addr()) return -ENODEV; if (edac_get_report_status() == EDAC_REPORTING_FORCE) {