From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C82C1C388F9 for ; Tue, 3 Nov 2020 21:02:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85EBE20658 for ; Tue, 3 Nov 2020 21:02:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437323; bh=l8Npg75/7aR5QkKyLswuwxgotvs6R6v/1W7zf+UCnOs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PYHeOBDbsFPeV4EXpkQF8c9Xo9yUuX2sz8taxtXhazKadnzCPYTThseATO+j6oLgT 5ZAF/PLFzlUg2mI/AWuEB01e0MB+UG27pWXaKCCVDfpNfAPAg+HeNKZPltjZJnPOII AHgzDAIRYajxUWxigrxpu76/2xE6ONwAK1edb81c= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387556AbgKCVCC (ORCPT ); Tue, 3 Nov 2020 16:02:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:38758 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387535AbgKCVB5 (ORCPT ); Tue, 3 Nov 2020 16:01:57 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 73766205ED; Tue, 3 Nov 2020 21:01:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437316; bh=l8Npg75/7aR5QkKyLswuwxgotvs6R6v/1W7zf+UCnOs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xAukX+xRT6qiAA5oB49XSFXSSB8EMCNsiL7Rdcize/39Bop0nURoSpykHXf7ipX4D e2a2i3fJKkIvKRbZY9wkMxn4Ksh2em1kMsbnmfhnQ37bl15NOsESsyjHrNfRREEwOW 9D9zkqheqQizbB5V8cGBQbBJx9QE1Doz9cc4H+DU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Frederic Barrat , Andrew Donnellan , Michael Ellerman Subject: [PATCH 4.19 024/191] cxl: Rework error message for incompatible slots Date: Tue, 3 Nov 2020 21:35:16 +0100 Message-Id: <20201103203235.826571834@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203232.656475008@linuxfoundation.org> References: <20201103203232.656475008@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frederic Barrat commit 40ac790d99c6dd16b367d5c2339e446a5f1b0593 upstream. Improve the error message shown if a capi adapter is plugged on a capi-incompatible slot directly under the PHB (no intermediate switch). Fixes: 5632874311db ("cxl: Add support for POWER9 DD2") Cc: stable@vger.kernel.org # 4.14+ Signed-off-by: Frederic Barrat Reviewed-by: Andrew Donnellan Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200407115601.25453-1-fbarrat@linux.ibm.com Signed-off-by: Greg Kroah-Hartman --- drivers/misc/cxl/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/misc/cxl/pci.c +++ b/drivers/misc/cxl/pci.c @@ -397,8 +397,8 @@ int cxl_calc_capp_routing(struct pci_dev *capp_unit_id = get_capp_unit_id(np, *phb_index); of_node_put(np); if (!*capp_unit_id) { - pr_err("cxl: invalid capp unit id (phb_index: %d)\n", - *phb_index); + pr_err("cxl: No capp unit found for PHB[%lld,%d]. Make sure the adapter is on a capi-compatible slot\n", + *chipid, *phb_index); return -ENODEV; }