From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47CE2C2D0A3 for ; Tue, 3 Nov 2020 21:26:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01CBA206E3 for ; Tue, 3 Nov 2020 21:26:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604438774; bh=PRcRl7R3oWl8ohIK2R4Otzk1s2ZFVg99JA92WUW2ILw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uFguHpc3/7xMSYM9XnuOgIAPge5IimErT2k2AGUiISCO/VeSs0WlsN5Qp+aavi9xL zyJLLQXVOFLiGY2x1k4K0sI4SGv0yKRyp6NQIGuSnPDBXn3VsujurBd2+ytWEnKNCk x+ArtunvV50vpOZyLQz29gKcAfK9kMDohw3+Zm/Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387537AbgKCVCF (ORCPT ); Tue, 3 Nov 2020 16:02:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:38838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387548AbgKCVCA (ORCPT ); Tue, 3 Nov 2020 16:02:00 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C50BA206B5; Tue, 3 Nov 2020 21:01:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437319; bh=PRcRl7R3oWl8ohIK2R4Otzk1s2ZFVg99JA92WUW2ILw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CCkXD33tJGxfbcyJDfwbhRj9ktXN/pxPVcKOV6INcsSzRSCG2VP5fIQHwSgcpMwzN 87Q46bKQRdYmGW208RAfUeqdtZDs2sIb+cCWyx2s1Q3/cB02nN99CtMj6XYnDnLSjg me9wt/Eoqe4y5ZQ/Hgk9RRdomuP7XrQh4ub0gMek= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Aloni , Leon Romanovsky , Jason Gunthorpe Subject: [PATCH 4.19 025/191] RDMA/addr: Fix race with netevent_callback()/rdma_addr_cancel() Date: Tue, 3 Nov 2020 21:35:17 +0100 Message-Id: <20201103203235.974272097@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203232.656475008@linuxfoundation.org> References: <20201103203232.656475008@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Gunthorpe commit 2ee9bf346fbfd1dad0933b9eb3a4c2c0979b633e upstream. This three thread race can result in the work being run once the callback becomes NULL: CPU1 CPU2 CPU3 netevent_callback() process_one_req() rdma_addr_cancel() [..] spin_lock_bh() set_timeout() spin_unlock_bh() spin_lock_bh() list_del_init(&req->list); spin_unlock_bh() req->callback = NULL spin_lock_bh() if (!list_empty(&req->list)) // Skipped! // cancel_delayed_work(&req->work); spin_unlock_bh() process_one_req() // again req->callback() // BOOM cancel_delayed_work_sync() The solution is to always cancel the work once it is completed so any in between set_timeout() does not result in it running again. Cc: stable@vger.kernel.org Fixes: 44e75052bc2a ("RDMA/rdma_cm: Make rdma_addr_cancel into a fence") Link: https://lore.kernel.org/r/20200930072007.1009692-1-leon@kernel.org Reported-by: Dan Aloni Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/core/addr.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/core/addr.c @@ -571,13 +571,12 @@ static void process_one_req(struct work_ req->callback = NULL; spin_lock_bh(&lock); + /* + * Although the work will normally have been canceled by the workqueue, + * it can still be requeued as long as it is on the req_list. + */ + cancel_delayed_work(&req->work); if (!list_empty(&req->list)) { - /* - * Although the work will normally have been canceled by the - * workqueue, it can still be requeued as long as it is on the - * req_list. - */ - cancel_delayed_work(&req->work); list_del_init(&req->list); kfree(req); }