From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43F2AC388F7 for ; Tue, 3 Nov 2020 21:23:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0AC0206B5 for ; Tue, 3 Nov 2020 21:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604438596; bh=8Ps6fibaEDvruRC1CSgKQZmovHRxfu5kwG0uq6P269M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bbOJjhIJE/linXhPb6XhMxdHnHp0JiA98HjDEy/EtKsjTZCDJiwtktTEQvGHKxb2N H25cZ7rjPVghPVnG6HrlSA38p5JEm/NP6Km+Yg8N89WKDSDh4jXaDs7Dg5corrmplQ AaJOAHgULcTV1dfBdkhxcb1hG9bIyEN2d26tX6TE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732980AbgKCVEr (ORCPT ); Tue, 3 Nov 2020 16:04:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:42914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387666AbgKCVEo (ORCPT ); Tue, 3 Nov 2020 16:04:44 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7578120658; Tue, 3 Nov 2020 21:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437483; bh=8Ps6fibaEDvruRC1CSgKQZmovHRxfu5kwG0uq6P269M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ECfbxvEaDDUqKBHnSAFOLpgb9VKmM8pViNMb44NOqnw4+NIWKAlBk3nRDB0ztdOtL iVgnS2Mp2K9rCA5YPK+Vn1so0/jn5me1ko8N1f1x1jL0yeoD10CFrhGEq5LGQnSeZL OBADihK02zoMrFn4rQy2ItJ2N7T059xhUEeV6nQA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Murphy , Tero Kristo , Stephen Boyd , Sasha Levin Subject: [PATCH 4.19 097/191] clk: ti: clockdomain: fix static checker warning Date: Tue, 3 Nov 2020 21:36:29 +0100 Message-Id: <20201103203242.893314467@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203232.656475008@linuxfoundation.org> References: <20201103203232.656475008@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tero Kristo [ Upstream commit b7a7943fe291b983b104bcbd2f16e8e896f56590 ] Fix a memory leak induced by not calling clk_put after doing of_clk_get. Reported-by: Dan Murphy Signed-off-by: Tero Kristo Link: https://lore.kernel.org/r/20200907082600.454-3-t-kristo@ti.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/clockdomain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/ti/clockdomain.c b/drivers/clk/ti/clockdomain.c index 07a805125e98c..11d92311e162f 100644 --- a/drivers/clk/ti/clockdomain.c +++ b/drivers/clk/ti/clockdomain.c @@ -146,10 +146,12 @@ static void __init of_ti_clockdomain_setup(struct device_node *node) if (clk_hw_get_flags(clk_hw) & CLK_IS_BASIC) { pr_warn("can't setup clkdm for basic clk %s\n", __clk_get_name(clk)); + clk_put(clk); continue; } to_clk_hw_omap(clk_hw)->clkdm_name = clkdm_name; omap2_init_clk_clkdm(clk_hw); + clk_put(clk); } } -- 2.27.0