From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68DA1C2D0A3 for ; Tue, 3 Nov 2020 21:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E6E2207BC for ; Tue, 3 Nov 2020 21:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437725; bh=lAvzIaZ5f5JLqCus98mw0Vf84esj8jxnWG8QHvEV+ag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Y4yZastSU8pq+Jfcm8Lgq4K+DZi+Az7ww3f4M7Twyll8jKV621j00TfjedFcQoFSn yOLnDzZz0SOcL3NyFkvK1qkLx0e3U92PtRBtS8P4lpSPXKeh1q2z2l9Xs50Ne9y9dU F/4wJsj3BhFePg5xcvPlgYVabStrIb3rNR4UcnQQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388598AbgKCVIn (ORCPT ); Tue, 3 Nov 2020 16:08:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:48064 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388531AbgKCVIi (ORCPT ); Tue, 3 Nov 2020 16:08:38 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D199207BC; Tue, 3 Nov 2020 21:08:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437718; bh=lAvzIaZ5f5JLqCus98mw0Vf84esj8jxnWG8QHvEV+ag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X4eO/krnc+KS94gWgzkXLj4QctKhMIHrpYg2jdWgOzSw0aVxxlMwHzondPwskKd0Q X15YLtohsngenoh28v0SAzdsR59D8aye7FAQL3y65Z6LHapYJM+Wt+nXX2kgauwveY u46ukheX5/o1KJDiFpEPFjDmWLIzfY920tm5SfB4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+9f864abad79fae7c17e1@syzkaller.appspotmail.com, Eric Biggers , Jan Kara , Theodore Tso Subject: [PATCH 4.19 173/191] ext4: fix leaking sysfs kobject after failed mount Date: Tue, 3 Nov 2020 21:37:45 +0100 Message-Id: <20201103203248.773799962@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203232.656475008@linuxfoundation.org> References: <20201103203232.656475008@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Biggers commit cb8d53d2c97369029cc638c9274ac7be0a316c75 upstream. ext4_unregister_sysfs() only deletes the kobject. The reference to it needs to be put separately, like ext4_put_super() does. This addresses the syzbot report "memory leak in kobject_set_name_vargs (3)" (https://syzkaller.appspot.com/bug?extid=9f864abad79fae7c17e1). Reported-by: syzbot+9f864abad79fae7c17e1@syzkaller.appspotmail.com Fixes: 72ba74508b28 ("ext4: release sysfs kobject when failing to enable quotas on mount") Cc: stable@vger.kernel.org Signed-off-by: Eric Biggers Link: https://lore.kernel.org/r/20200922162456.93657-1-ebiggers@kernel.org Reviewed-by: Jan Kara Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -4594,6 +4594,7 @@ cantfind_ext4: failed_mount8: ext4_unregister_sysfs(sb); + kobject_put(&sbi->s_kobj); failed_mount7: ext4_unregister_li_request(sb); failed_mount6: