From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120AAC2D0A3 for ; Tue, 3 Nov 2020 21:42:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D326222384 for ; Tue, 3 Nov 2020 21:42:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604439753; bh=XnYA1QIdRA55JZUyQQp0PDa7+crtbkaPzu+EXOaXmNg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tAHHizSJH7ExBKkOeB0+6T/nYoe3mVcstein5TdHn5E4NdCmJtp2oaO4oOvHTaSYQ fQfPcDX2sjVurhHnUSQ39jgq5si7FvBPP6zvheqXwAnn/3QyWU62MHJ1Uc5a1ojZMf GTZlfvN5nJ2Sqy8CyDpMrQnTLKzUyCS0QnAtxR3E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732903AbgKCVmc (ORCPT ); Tue, 3 Nov 2020 16:42:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:56148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732334AbgKCUzb (ORCPT ); Tue, 3 Nov 2020 15:55:31 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00D92223BD; Tue, 3 Nov 2020 20:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604436931; bh=XnYA1QIdRA55JZUyQQp0PDa7+crtbkaPzu+EXOaXmNg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NcxR+RphhdBl64A2EVyXg5R/0RSfyptrjp5j2x9ej0UKaf7Jv8KWIcYhSsT6c0ZsB rrt4VAgvdwJ58pksZvqxk8k7cD1MUW/7YtPl3GVO+QGnzF5KeXyhLo3gnm2f3fp68j +gnTZpWRgd1uTx+rmlEGAJvcOhBIufGjAgiabews= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tom Rix , Arnd Bergmann , Sam Ravnborg , Sasha Levin Subject: [PATCH 5.4 035/214] video: fbdev: pvr2fb: initialize variables Date: Tue, 3 Nov 2020 21:34:43 +0100 Message-Id: <20201103203253.379247598@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203249.448706377@linuxfoundation.org> References: <20201103203249.448706377@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tom Rix [ Upstream commit 8e1ba47c60bcd325fdd097cd76054639155e5d2e ] clang static analysis reports this repesentative error pvr2fb.c:1049:2: warning: 1st function call argument is an uninitialized value [core.CallAndMessage] if (*cable_arg) ^~~~~~~~~~~~~~~ Problem is that cable_arg depends on the input loop to set the cable_arg[0]. If it does not, then some random value from the stack is used. A similar problem exists for output_arg. So initialize cable_arg and output_arg. Signed-off-by: Tom Rix Acked-by: Arnd Bergmann Signed-off-by: Sam Ravnborg Link: https://patchwork.freedesktop.org/patch/msgid/20200720191845.20115-1-trix@redhat.com Signed-off-by: Sasha Levin --- drivers/video/fbdev/pvr2fb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/video/fbdev/pvr2fb.c b/drivers/video/fbdev/pvr2fb.c index 0a3b2b7c78912..c916e91614436 100644 --- a/drivers/video/fbdev/pvr2fb.c +++ b/drivers/video/fbdev/pvr2fb.c @@ -1016,6 +1016,8 @@ static int __init pvr2fb_setup(char *options) if (!options || !*options) return 0; + cable_arg[0] = output_arg[0] = 0; + while ((this_opt = strsep(&options, ","))) { if (!*this_opt) continue; -- 2.27.0