From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53FC9C2D0A3 for ; Tue, 3 Nov 2020 21:29:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 098CD2236F for ; Tue, 3 Nov 2020 21:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604438944; bh=PhZiF3/f8TONGTYt4osYsdHZsjC/HvsaoqTj5qrAW6M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=kB9mkEk7qeoGEfeyNZgQSWwDv1jUTqyMSquDN7JaCCf7N9vDd44Hp6k67vVHg0vAc LNfTIxDzhtQAY4nd09Ux2oxgXZh8M8+rtYWi3HyVF14++h4L6YN7eMxk5P+DGTx5Za yl12Iedqa0m+D776v8AO0xZOHSpx+R6Akb+96/x4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387654AbgKCV3D (ORCPT ); Tue, 3 Nov 2020 16:29:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:35408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733167AbgKCU75 (ORCPT ); Tue, 3 Nov 2020 15:59:57 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A7A9522226; Tue, 3 Nov 2020 20:59:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604437197; bh=PhZiF3/f8TONGTYt4osYsdHZsjC/HvsaoqTj5qrAW6M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tmI7Q/iE8bfb9GdiuiGJoEIEYf+YZCDx4Euxi8eG1GTghz2+YJLIgST3Go8GhiOfB 0l2iD7rSfYQek+csW67Vph8yKqYQblQyJ7+QRDbYvISoQSOc+KnmMlJCDvDousnZxV ppONBEnTRr+1/jbZ5ouqivsTAdfEut4icgGlV8zI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Matthew Wilcox (Oracle)" , Jeff Layton , Ilya Dryomov Subject: [PATCH 5.4 187/214] ceph: promote to unsigned long long before shifting Date: Tue, 3 Nov 2020 21:37:15 +0100 Message-Id: <20201103203308.219605906@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201103203249.448706377@linuxfoundation.org> References: <20201103203249.448706377@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthew Wilcox (Oracle) commit c403c3a2fbe24d4ed33e10cabad048583ebd4edf upstream. On 32-bit systems, this shift will overflow for files larger than 4GB. Cc: stable@vger.kernel.org Fixes: 61f68816211e ("ceph: check caps in filemap_fault and page_mkwrite") Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Jeff Layton Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- fs/ceph/addr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ceph/addr.c +++ b/fs/ceph/addr.c @@ -1427,7 +1427,7 @@ static vm_fault_t ceph_filemap_fault(str struct ceph_inode_info *ci = ceph_inode(inode); struct ceph_file_info *fi = vma->vm_file->private_data; struct page *pinned_page = NULL; - loff_t off = vmf->pgoff << PAGE_SHIFT; + loff_t off = (loff_t)vmf->pgoff << PAGE_SHIFT; int want, got, err; sigset_t oldset; vm_fault_t ret = VM_FAULT_SIGBUS;