From: Oded Gabbay <ogabbay@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: SW_Drivers@habana.ai, Ofir Bitton <obitton@habana.ai>
Subject: [PATCH] habanalabs/gaudi: remove unreachable code
Date: Wed, 4 Nov 2020 10:36:27 +0200 [thread overview]
Message-ID: <20201104083630.28402-5-ogabbay@kernel.org> (raw)
In-Reply-To: <20201104083630.28402-1-ogabbay@kernel.org>
From: Ofir Bitton <obitton@habana.ai>
Remove unreachable code in gaudi collective flow.
Signed-off-by: Ofir Bitton <obitton@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
---
drivers/misc/habanalabs/gaudi/gaudi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
index f73e508cf14c..8b02d6341b4c 100644
--- a/drivers/misc/habanalabs/gaudi/gaudi.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi.c
@@ -1224,10 +1224,8 @@ static int gaudi_collective_wait_create_jobs(struct hl_device *hdev,
if (collective_engine_id == GAUDI_ENGINE_ID_DMA_5)
collective_queue = GAUDI_QUEUE_ID_DMA_5_0 + stream;
- else if (collective_engine_id == GAUDI_ENGINE_ID_TPC_7)
- collective_queue = GAUDI_QUEUE_ID_TPC_7_0 + stream;
else
- return -EINVAL;
+ collective_queue = GAUDI_QUEUE_ID_TPC_7_0 + stream;
num_jobs = NUMBER_OF_SOBS_IN_GRP + 1;
nic_queue = GAUDI_QUEUE_ID_NIC_0_0 + stream;
--
2.17.1
next prev parent reply other threads:[~2020-11-04 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 8:36 [PATCH] habanalabs: advanced FW loading Oded Gabbay
2020-11-04 8:36 ` [PATCH 1/2] habanalabs: fetch security indication from FW Oded Gabbay
2020-11-04 8:36 ` [PATCH] habanalabs: fix cs counters structure Oded Gabbay
2020-11-04 8:36 ` [PATCH] habanalabs/gaudi: monitor device memory usage Oded Gabbay
2020-11-04 8:36 ` Oded Gabbay [this message]
2020-11-04 8:36 ` [PATCH] habanalabs: initialize variable before use Oded Gabbay
2020-11-04 8:36 ` [PATCH] habanalabs: make sure cs type is valid in cs_ioctl_signal_wait Oded Gabbay
2020-11-04 8:36 ` [PATCH 2/2] habanalabs/gaudi: add support for FW security Oded Gabbay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104083630.28402-5-ogabbay@kernel.org \
--to=ogabbay@kernel.org \
--cc=SW_Drivers@habana.ai \
--cc=linux-kernel@vger.kernel.org \
--cc=obitton@habana.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox