From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9463C388F7 for ; Wed, 4 Nov 2020 08:36:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 751F120781 for ; Wed, 4 Nov 2020 08:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604479007; bh=9r2bTbSzkjI/1caHR/FRV4CdE+MkCdrY9CHmiMPWasQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jBAPk7sAd07GQqxrj9+tFL5yb7Z9TljGGld/8fBUdU58OuEU1MfExQH2CUuXTODhG 4N0KgqZEBY6SBcc08HBfk1CfWTD/MTz7RSKm/93RW5zLsgZNYmDat+cQjYZ1IFFrRn 4CVW3Z3Rv0qHROQ8fzBhVxNHUfo+Y1HKYuSSthYM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728811AbgKDIgq (ORCPT ); Wed, 4 Nov 2020 03:36:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:56388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728675AbgKDIgm (ORCPT ); Wed, 4 Nov 2020 03:36:42 -0500 Received: from ogabbay-VM.habana-labs.com (unknown [213.57.90.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0AAD020781; Wed, 4 Nov 2020 08:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604479002; bh=9r2bTbSzkjI/1caHR/FRV4CdE+MkCdrY9CHmiMPWasQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N2wFHuj4Qpb/1EpjQtjBZUBCYoe0IH6E8BotEQVgHPE73AieIBOcuWytDzkju+IYd d0lGnkHrU0WH783af0hMIGyQuwgT86AyUL1vfAqgD3EmS41xRWuZeC+ArJmfyBWz0L qMZRHF6Qlhs7VGOXdL41SBswr5NLfceCRuzyCnKM= From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: SW_Drivers@habana.ai, Ofir Bitton Subject: [PATCH] habanalabs/gaudi: remove unreachable code Date: Wed, 4 Nov 2020 10:36:27 +0200 Message-Id: <20201104083630.28402-5-ogabbay@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201104083630.28402-1-ogabbay@kernel.org> References: <20201104083630.28402-1-ogabbay@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ofir Bitton Remove unreachable code in gaudi collective flow. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c index f73e508cf14c..8b02d6341b4c 100644 --- a/drivers/misc/habanalabs/gaudi/gaudi.c +++ b/drivers/misc/habanalabs/gaudi/gaudi.c @@ -1224,10 +1224,8 @@ static int gaudi_collective_wait_create_jobs(struct hl_device *hdev, if (collective_engine_id == GAUDI_ENGINE_ID_DMA_5) collective_queue = GAUDI_QUEUE_ID_DMA_5_0 + stream; - else if (collective_engine_id == GAUDI_ENGINE_ID_TPC_7) - collective_queue = GAUDI_QUEUE_ID_TPC_7_0 + stream; else - return -EINVAL; + collective_queue = GAUDI_QUEUE_ID_TPC_7_0 + stream; num_jobs = NUMBER_OF_SOBS_IN_GRP + 1; nic_queue = GAUDI_QUEUE_ID_NIC_0_0 + stream; -- 2.17.1