From: Dan Carpenter <dan.carpenter@oracle.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-kernel@vger.kernel.org,
Souptick Joarder <jrdr.linux@gmail.com>,
devel@driverdev.osuosl.org, linux-media@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Ira Weiny <ira.weiny@intel.com>,
John Hubbard <jhubbard@nvidia.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Michel Lespinasse <walken@google.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [v2] media: atomisp: Fix error handling path
Date: Wed, 4 Nov 2020 14:40:15 +0300 [thread overview]
Message-ID: <20201104114015.GH18329@kadam> (raw)
In-Reply-To: <85ff17ad-8aa7-a457-6e23-4f5c1c5152f2@web.de>
On Wed, Nov 04, 2020 at 11:30:29AM +0100, Markus Elfring wrote:
> >>> Fixes: 14a638ab96c5 ("media: atomisp: use pin_user_pages() for memory
> >>> allocation")
> >>
> >> Please delete a line break for this tag.
> >
> > Markus, the thing is that we all saw the line break and we just thought
> > it didn't matter at all...
>
> Do you disagree to the known documentation then?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=4ef8451b332662d004df269d4cdeb7d9f31419b5#n123
The documentation is correct but no one wants you to constantly be
nagging developers about minor stuff...
One thing that I do is I start to write an email and then if I realize
it's not worth complaining about and I save it to my postponed messages
folder. Then I never send it and I forget about it completely. I have
currently have 740 messages in my postponed messages folder. :P
That's a lot of whining and complaining which I never sent and the world
is the more beautiful for it.
regards,
dan carpenter
next prev parent reply other threads:[~2020-11-04 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 2:02 [PATCH v2] media: atomisp: Fixed error handling path Souptick Joarder
[not found] ` <65712450-1ee9-2dd3-cd43-f850807ae203@web.de>
2020-11-04 8:31 ` [PATCH v2] media: atomisp: Fix " Dan Carpenter
[not found] ` <85ff17ad-8aa7-a457-6e23-4f5c1c5152f2@web.de>
2020-11-04 11:40 ` Dan Carpenter [this message]
2020-11-18 19:36 ` [PATCH v2] media: atomisp: Fixed " Souptick Joarder
2020-12-08 19:48 ` Souptick Joarder
2020-12-29 7:48 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104114015.GH18329@kadam \
--to=dan.carpenter@oracle.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=ira.weiny@intel.com \
--cc=jhubbard@nvidia.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox