From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD1CC388F7 for ; Wed, 4 Nov 2020 14:10:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99801221E2 for ; Wed, 4 Nov 2020 14:10:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604499001; bh=oqi/1AeJXFRea73PjIiA42SQZSDLRDeYDOWMlP0y20I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LhTRRjRCp9fjxRbFxG2oCmov3C71RFxut7E3AuffzHfNxtqLYCvQ6ThuJbziY4X/7 /sgG0601GbKW7zYo1Lc6S/R8R6iyx9aBr0f4XCNBLCRU7axYs6axzYyRAhiKc+SiWM 24WjSvaQu70c1M2MV5s7V3ADtrknKcqK+opdnUNY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730277AbgKDOKA (ORCPT ); Wed, 4 Nov 2020 09:10:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:37796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730139AbgKDOJe (ORCPT ); Wed, 4 Nov 2020 09:09:34 -0500 Received: from ogabbay-VM.habana-labs.com (unknown [213.57.90.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8883223BD; Wed, 4 Nov 2020 14:09:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604498974; bh=oqi/1AeJXFRea73PjIiA42SQZSDLRDeYDOWMlP0y20I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cDWBXFyoj+HrH5wsE7XLeNMngestyDFPfd+yRpJWwYa/xE1mJ+vTnqcmPSPPXC7eI xRv0ztRrzmABNAY6228xzEQo5QgmNHpZecXWfQdTtwkhmJGbaWiQuS7bg5gJ5dB8qe c4b0kbBj7AAmtdfpsE6xxdy4mPwkcYBuDgzJckDs= From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: SW_Drivers@habana.ai, Tomer Tayar Subject: [PATCH] habanalabs: Skip updating CI of internal queues if not in use Date: Wed, 4 Nov 2020 16:09:07 +0200 Message-Id: <20201104140908.10178-11-ogabbay@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201104140908.10178-1-ogabbay@kernel.org> References: <20201104140908.10178-1-ogabbay@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tomer Tayar There are no internal queues if H/W queues are being used. In this case we can skip the redundant traversal over the queues array, looking for internal queues. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/hw_queue.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/misc/habanalabs/common/hw_queue.c b/drivers/misc/habanalabs/common/hw_queue.c index 239e2ba0545f..84a7458f3363 100644 --- a/drivers/misc/habanalabs/common/hw_queue.c +++ b/drivers/misc/habanalabs/common/hw_queue.c @@ -48,6 +48,11 @@ void hl_int_hw_queue_update_ci(struct hl_cs *cs) return; q = &hdev->kernel_queues[0]; + + /* There are no internal queues if H/W queues are being used */ + if (!hdev->asic_prop.max_queues || q->queue_type == QUEUE_TYPE_HW) + return; + for (i = 0 ; i < hdev->asic_prop.max_queues ; i++, q++) { if (q->queue_type == QUEUE_TYPE_INT) atomic_add(cs->jobs_in_queue_cnt[i], &q->ci); -- 2.17.1