From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC63C2D0A3 for ; Wed, 4 Nov 2020 14:38:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC12720756 for ; Wed, 4 Nov 2020 14:38:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729972AbgKDOin (ORCPT ); Wed, 4 Nov 2020 09:38:43 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:35150 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729839AbgKDOin (ORCPT ); Wed, 4 Nov 2020 09:38:43 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kaJvq-005DwP-BX; Wed, 04 Nov 2020 15:38:38 +0100 Date: Wed, 4 Nov 2020 15:38:38 +0100 From: Andrew Lunn To: Lee Jones Cc: Ivan Khoronzhuk , netdev@vger.kernel.org, "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 06/12] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Message-ID: <20201104143838.GD1213539@lunn.ch> References: <20201104090610.1446616-1-lee.jones@linaro.org> <20201104090610.1446616-7-lee.jones@linaro.org> <20201104133354.GA933237@lunn.ch> <20201104142835.GD4488@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104142835.GD4488@dell> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 04, 2020 at 02:28:35PM +0000, Lee Jones wrote: > On Wed, 04 Nov 2020, Andrew Lunn wrote: > > > On Wed, Nov 04, 2020 at 09:06:04AM +0000, Lee Jones wrote: > > > Fixes the following W=1 kernel build warning(s): > > > > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'ndev' not described in 'am65_cpsw_timer_set' > > > drivers/net/ethernet/ti/am65-cpsw-qos.c:364: warning: Function parameter or member 'est_new' not described in 'am65_cpsw_timer_set' > > > > > > Cc: "David S. Miller" > > > Cc: Jakub Kicinski > > > Cc: Ivan Khoronzhuk > > > Cc: "Gustavo A. R. Silva" > > > Cc: netdev@vger.kernel.org > > > Signed-off-by: Lee Jones > > > > Reviewed-by: Andrew Lunn > > > > I _think_ these have got missed so far in the various cleanup passes > > because of missing COMPILE_TEST. I've been adding that as part of > > fixing these warnings. When your respin, could you add that as well? > > Yes, no problem. > > Just for this symbol? Hi Lee I've not look at the Kbuild, but ideally so that all TI drivers get built when COMPILE_TEST is true. And this probably needs to happen for any patch i added a Reviewed-by: because i missed them as well. I'm using COMPILE_TEST but just for arm and x86, where as i guess you are using more randconfig builds, or less popular architectures? Andrew