Re: [PATCH v9 5/7] rcu/segcblist: Remove useless rcupdate.h include

Paul E. McKenney
2020-11-05T03:48:35Z

On Tue, Nov 03, 2020 at 09:26:01AM -0500, Joel Fernandes (Google) wrote:
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>

This one looks fine, but depends on the earlier "rcu/segcblist: Add
counters to segcblist datastructure" patch, which also changes the list
of #include directives for this file. It manages to avoid conflicting
with "rcu/trace: Add tracing for how segcb list changes", despite this
one also changing the #include directives.

I am testing it just out of curiosity, but it might make more sense
to fold this one into "rcu/segcblist: Add counters to segcblist
datastructure".

Thanx, Paul

> ---
> kernel/rcu/rcu_segcblist.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/rcu/rcu_segcblist.c b/kernel/rcu/rcu_segcblist.c
> index 2a03949d0b82..e9e72d72f7a6 100644
> --- a/kernel/rcu/rcu_segcblist.c
> +++ b/kernel/rcu/rcu_segcblist.c
> @@ -10,7 +10,6 @@
> #include <linux/cpu.h>
> #include <linux/interrupt.h>
> #include <linux/kernel.h>
> -#include <linux/rcupdate.h>
> #include <linux/types.h>
>
> #include "rcu_segcblist.h"
> --
> 2.29.1.341.ge80a0c044ae-goog
>