Re: [PATCH v3 1/2] perf lock: Correct field name "flags"

Arnaldo Carvalho de Melo
2020-11-04T16:21:55Z

Em Wed, Nov 04, 2020 at 05:42:28PM +0800, Leo Yan escreveu:
> The tracepoint "lock:lock_acquire" contains field "flags" but not
> "flag". Current code wrongly retrieves value from field "flag" and it
> always gets zero for the value, thus "perf lock" doesn't report the
> correct result.
>
> This patch replaces the field name "flag" with "flags", so can read out
> the correct flags for locking.

Thanks, applied both patches.

- Arnaldo

> Fixes: e4cef1f65061 ("perf lock: Fix state machine to recognize lock sequence")
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> Acked-by: Jiri Olsa <jolsa@redhat.com>
> ---
> tools/perf/builtin-lock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-lock.c b/tools/perf/builtin-lock.c
> index f0a1dbacb46c..5cecc1ad78e1 100644
> --- a/tools/perf/builtin-lock.c
> +++ b/tools/perf/builtin-lock.c
> @@ -406,7 +406,7 @@ static int report_lock_acquire_event(struct evsel *evsel,
> struct lock_seq_stat *seq;
> const char *name = evsel__strval(evsel, sample, "name");
> u64 tmp = evsel__intval(evsel, sample, "lockdep_addr");
> - int flag = evsel__intval(evsel, sample, "flag");
> + int flag = evsel__intval(evsel, sample, "flags");
>
> memcpy(&addr, &tmp, sizeof(void *));
>
> --
> 2.17.1
>

--

- Arnaldo