From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A739CC2D0A3 for ; Wed, 4 Nov 2020 16:27:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61666206D4 for ; Wed, 4 Nov 2020 16:27:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731251AbgKDQ1q (ORCPT ); Wed, 4 Nov 2020 11:27:46 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:35548 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730966AbgKDQ1p (ORCPT ); Wed, 4 Nov 2020 11:27:45 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kaLdG-005F6t-Hc; Wed, 04 Nov 2020 17:27:34 +0100 Date: Wed, 4 Nov 2020 17:27:34 +0100 From: Andrew Lunn To: Sven Van Asbroeck Cc: Bryan Whitehead , David S Miller , Jakub Kicinski , Microchip Linux Driver Support , Roelof Berg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] lan743x: correctly handle chips with internal PHY Message-ID: <20201104162734.GA1249360@lunn.ch> References: <20201104160847.30049-1-TheSven73@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201104160847.30049-1-TheSven73@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Note that as a side-effect, the devicetree phy mode now no longer > has a default, and always needs to be specified explicitly (via > 'phy-connection-type'). That sounds like it could break systems. Why do you do this? Andrew