Re: [PATCH 1/1] x86/tools: Use tools headers for instruction decoder selftests

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3207 bytes --]

Hi Vasily,

I love your patch! Yet something to improve:

[auto build test ERROR on tip/x86/core]
[also build test ERROR on v5.10-rc2 next-20201103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Vasily-Gorbik/x86-tools-Use-tools-headers-for-instruction-decoder-selftests/20201104-043600
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 238c91115cd05c71447ea071624a4c9fe661f970
config: x86_64-randconfig-s022-20201103 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-76-gf680124b-dirty
        # https://github.com/0day-ci/linux/commit/ab4952becdfae8a76a6f0e0fb4ec7d078e80d5d6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vasily-Gorbik/x86-tools-Use-tools-headers-for-instruction-decoder-selftests/20201104-043600
        git checkout ab4952becdfae8a76a6f0e0fb4ec7d078e80d5d6
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

   In file included from arch/x86/tools/insn_sanity.c:19:
   tools/arch/x86/lib/insn.c: In function '__insn_get_emulate_prefix':
>> tools/arch/x86/lib/insn.c:32:9: warning: implicit declaration of function 'unlikely' [-Wimplicit-function-declaration]
      32 |  ({ if (unlikely(!validate_next(t, insn, n))) goto err_out; __peek_nbyte_next(t, insn, n); })
         |         ^~~~~~~~
   tools/arch/x86/lib/insn.c:72:7: note: in expansion of macro 'peek_nbyte_next'
      72 |   if (peek_nbyte_next(insn_byte_t, insn, i) != prefix[i])
         |       ^~~~~~~~~~~~~~~
   arch/x86/tools/insn_sanity.c: In function 'read_next_insn':
>> arch/x86/tools/insn_sanity.c:128:19: warning: implicit declaration of function 'ARRAY_SIZE' [-Wimplicit-function-declaration]
     128 |  tmp = fgets(buf, ARRAY_SIZE(buf), input_file);
         |                   ^~~~~~~~~~
   /usr/bin/ld: /tmp/ccO69OOl.o: in function `__insn_get_emulate_prefix.constprop.0':
>> insn_sanity.c:(.text+0x417): undefined reference to `unlikely'
   /usr/bin/ld: /tmp/ccO69OOl.o: in function `insn_get_prefixes':
   insn_sanity.c:(.text+0x647): undefined reference to `unlikely'
>> /usr/bin/ld: insn_sanity.c:(.text+0x6b7): undefined reference to `unlikely'
   /usr/bin/ld: insn_sanity.c:(.text+0x744): undefined reference to `unlikely'
   /usr/bin/ld: insn_sanity.c:(.text+0x77f): undefined reference to `unlikely'
   /usr/bin/ld: /tmp/ccO69OOl.o:insn_sanity.c:(.text+0x817): more undefined references to `unlikely' follow
   /usr/bin/ld: /tmp/ccO69OOl.o: in function `main':
>> insn_sanity.c:(.text.startup+0x48a): undefined reference to `ARRAY_SIZE'
   collect2: error: ld returned 1 exit status

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33892 bytes --]