Re: [PATCH v1 13/18] driver core: Add fwnode_get_next_parent_dev() helper function

Saravana Kannan
2020-11-21T02:01:50Z

On Mon, Nov 16, 2020 at 8:27 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Thu, Nov 5, 2020 at 12:24 AM Saravana Kannan <saravanak@google.com> wrote:
> >
> > Given a fwnode, this function finds the closest ancestor fwnode that has
> > a corresponding struct device. The function returns this struct device.
> > This function will be used in a subsequent patch in this series.
> >
> > Signed-off-by: Saravana Kannan <saravanak@google.com>
>
> I would combine this one with patch [10/18].

Ack.

-Saravana

-Saravana

>
> > ---
> > drivers/base/core.c | 25 +++++++++++++++++++++++++
> > 1 file changed, 25 insertions(+)
> >
> > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > index ee28d8c7ee85..4ae5f2885ac5 100644
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -1562,6 +1562,31 @@ static void fw_devlink_parse_fwtree(struct fwnode_handle *fwnode)
> > fw_devlink_parse_fwtree(child);
> > }
> >
> > +/**
> > + * fwnode_get_next_parent_dev - Find device of closest ancestor fwnode
> > + * @fwnode: firmware node
> > + *
> > + * Given a firmware node (@fwnode), this function finds its closest ancestor
> > + * firmware node that has a corresponding struct device and returns that struct
> > + * device.
> > + *
> > + * The caller of this function is expected to call put_device() on the returned
> > + * device when they are done.
> > + */
> > +static struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode)
> > +{
> > + struct device *dev = NULL;
> > +
> > + fwnode_handle_get(fwnode);
> > + do {
> > + fwnode = fwnode_get_next_parent(fwnode);
> > + if (fwnode)
> > + dev = get_dev_from_fwnode(fwnode);
> > + } while (fwnode && !dev);
> > + fwnode_handle_put(fwnode);
> > + return dev;
> > +}
> > +
> > static void fw_devlink_link_device(struct device *dev)
> > {
> > int fw_ret;
> > --
> > 2.29.1.341.ge80a0c044ae-goog
> >