Re: [RFC v4 2/3] vfio/platform: change cleanup order

Auger Eric
2021-02-08T13:34:13Z

Hi Vikas,

On 1/29/21 6:24 PM, Vikas Gupta wrote:
> In the case of msi, vendor specific msi module may require
> region access to handle msi cleanup so we need to cleanup region
> after irq cleanup only.
>
> Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
Acked-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric

> ---
> drivers/vfio/platform/vfio_platform_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/platform/vfio_platform_common.c b/drivers/vfio/platform/vfio_platform_common.c
> index f2b1f0c3bfcc..1cc040e3ed1f 100644
> --- a/drivers/vfio/platform/vfio_platform_common.c
> +++ b/drivers/vfio/platform/vfio_platform_common.c
> @@ -243,8 +243,8 @@ static void vfio_platform_release(void *device_data)
> WARN_ON(1);
> }
> pm_runtime_put(vdev->device);
> - vfio_platform_regions_cleanup(vdev);
> vfio_platform_irq_cleanup(vdev);
> + vfio_platform_regions_cleanup(vdev);
> }
>
> mutex_unlock(&driver_lock);
>