Re: [PATCH] applesmc: Re-work SMC comms v2

Guenter Roeck
2020-11-06T03:08:19Z

On 11/5/20 4:02 PM, Brad Campbell wrote:
[ ... ]
>>> +/* Apple SMC status bits */
>>> +#define SMC_STATUS_AWAITING_DATA BIT(0) /* SMC has data waiting */
>>> +#define SMC_STATUS_IB_CLOSED BIT(1) /* Will ignore any input */
>>> +#define SMC_STATUS_BUSY BIT(2) /* Command in progress */
>>> +
>>
>> Hah, tricked you here ;-). Using "BIT()" requires
>>
>> #include <linux/bits.h>
>
> "requires" ??
> It compiles and tests without warning, but I'll certainly add it in.
>

Each driver should include the files with the declarations it needs, and
not depend on some indirect includes. Those indirect includes are not guaranteed
to exist and may be removed at some point in the future. "It compiles" is most
definitely not a valid argument.

Guenter