Re: [PATCH] applesmc: Re-work SMC comms v2

Andreas Kemnade
2020-11-05T08:16:30Z

On Thu, 5 Nov 2020 08:56:04 +0100
Henrik Rydberg <rydberg@bitmath.org> wrote:

> Hi Brad,
>
> Great to see this effort, it is certainly an area which could be
> improved. After having seen several generations of Macbooks while
> modifying much of that code, it became clear that the SMC communication
> got refreshed a few times over the years. Every tiny change had to be
> tested on all machines, or kept separate for a particular generation, or
> something would break.
>
> I have not followed the back story here, but I imagine the need has
> arisen because of a new refresh, and so this patch only needs to
> strictly apply to a new generation. I would therefore advice that you
> write the patch in that way, reducing the actual change to zero for
> earlier generations. It also makes it easier to test the effect of the
> new approach on older systems. I should be able to help testing on a
> 2008 and 2011 model once we get to that stage.
>
Well, the issue has arisen because of a change in kernel to make clang
happy. So it is not a new Apple device causing trouble.

Regards,
Andreas